On 5/21/08, Enno Gottox Boland <[EMAIL PROTECTED]> wrote:
> Here's my version of a bitarray patch. Please review and comment.

in config.h referencing tags has changed in rules but not in keys.

the (1 << tagnum) in rules is a bit nasty
it is probably nicer to do the shifting in setup();

instead of
 i < LENGTH(tags) && i < sizeof(int) * 8;
what about checking once
 if(LENGTH(tags) > sizeof(int) * CHAR_BIT)
     eprint("Maximum number of tags: %d\n", sizeof(int) * CHAR_BIT);
in setup();

Reply via email to