On Tue, Jun 10, 2008 at 10:58:40AM +0200, Premysl Hruby wrote: > On (10/06/08 10:51), Anselm R. Garbe wrote: > > To: dynamic window manager <[email protected]> > > From: "Anselm R. Garbe" <[EMAIL PROTECTED]> > > Subject: Re: [dwm] patch > > > > On Tue, Jun 10, 2008 at 10:38:55AM +0200, Premysl Hruby wrote: > > > - reintroducion of union Arg > > > > I don't like this, because intialization gets slightly > > cumbersome, I really prefer void * here. > > Imho it's much more cleaner then these const void *, is it don't hinder > the type etc. And initialization looks cleaner too. And union has been > created just for this usage, as replace for type magic.
Well for the predifined builtin key handlers this is right. However, const void * allows extensions to use structs of certain kinds directly as input, whereas the union needs to be redefined in such cases. However a solution to this problem is of course introducing void * as part of the union. So I'm open for introducing this change. The problem is, we should do that before 5.0 to keep updates to config.h at a minimum after 5.0. Kind regards, -- Anselm R. Garbe >< http://www.suckless.org/ >< GPG key: 0D73F361
