On Thu, Aug 14, 2008 at 04:21:39PM +0200, Szabolcs Nagy wrote: > On 8/14/08, Martin Hurton <[EMAIL PROTECTED]> wrote: > > Can you apply the following patch too? According to spec the > > XGetTransientForHint() function returns non zero value on success > > while the Success value is defined as zero (see /usr/include/X11/X.h). > > I'm not quite sure about this change. > > eg. X reference manual never states explicitly that GrabSuccess is 0 > (even though if one reads the X protocol specification he can *guess* > that it should be 0) so the programmer shouldn't rely on this. > > but if it's changed then change consistently: > $ grep Success dwm.c |wc -l > 6 Those other checks seems ok to me.
/Martin
