On Thu, Aug 28, 2008 at 03:56:04PM -0700, Donald Chai wrote:
>> Thanks for the patches, scrollback is probably the most requested
>> dvtm feature. You introduced a separate buffer for the scrollback
>> data, did you consider allocating more space for the main buffer and
>> just adjusting the scroll_{top,bot} pointers and using them in
>> madtty_draw to draw only the currently visible area?
>
> I did consider that, actually. Several reasons why I use a separate
> buffer:
> - From what I understand of vt100/xterm behavior, you can use DECSTBM
> to
> set the scrolling region. If the top line of the screen is *not* in the
> scrolling region, you'd need to do some extra work to have text scroll
> offscreen.
> - The scrollback buffer is a circular buffer for runtime efficiency,
> while the screen is a regular array.
> - I'd like to add some kind of compression for the scrollback buffer
> (e.g. run length encoding for character attributes, convert from wchar_t
> using wcsrtombs).
Ok i see, makes sense. I have commited your patch and added the
possibility to set the size of the scroll back history buffer at
runtime. Hope I didn't screw it up ;)
Thanks,
Marc
--
Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0
