Test for capabilities instead of GDMSESSION
** Attachment added: "339847.debdiff" http://launchpadlibrarian.net/24570892/339847.debdiff ** Changed in: system-config-printer (Ubuntu) Status: Triaged => In Progress -- system-config-printer notification patch should auto-detect capabilities of notification daemon, so that it can get upstreamized https://bugs.launchpad.net/bugs/339847 You received this bug notification because you are a member of Canonical Desktop Experience Team, which is a direct subscriber. Status in System Config Printer: Confirmed Status in “system-config-printer” source package in Ubuntu: In Progress Bug description: Binary package hint: system-config-printer Recently the default notification daemon in Ubuntu was replaced by a notify-osd which does not support action buttons. Therefore system-config-printer was patched to work without action buttons if needed, by using pop-up dialogs. Unfortunately this patch cannot be applied upstream, as the check for the notification daemon type is done in a Ubuntu-specific way: if os.environ.get('GDMSESSION') == "gnome-stracciatella": This should be replaced by a generic check on the notification daemon capabilities, using the Python equivalent of the function GList *notify_get_server_caps(void); (/usr/include/libnotify/notify.h). It should be "pynotify.get_server_caps()". As there are notification daemons with and without action button support, the assumption of system-config-printer to have action button support is an upstream bug which can be fixed by upstreamizing this patch. Ken VanDine, can you please fix the patch? Thanks. _______________________________________________ Mailing list: https://launchpad.net/~dx-team Post to : [email protected] Unsubscribe : https://launchpad.net/~dx-team More help : https://help.launchpad.net/ListHelp
