While experimenting a bit more, it seems my patch breaks normal replaces functionality. I'm looking into it right now; just don't do anything drastic with the code above...
Could i ask for a couple clarifications in the spec. What is to happen if replaces_id is also set when trying to append to a bubble? My interpretation says that appending takes precedence over replacing but I just wanted to make sure. Because of my little replacing oversight, the result is a smidgen less beautiful but it's still readable... I diffed it against the HEAD (or similar for bzr), not against my previous patch ** Attachment added: "Append using title and sender, Does not destroy replacing via replaces_id" http://launchpadlibrarian.net/24801009/append_by_title_and_sender_fix-r2.diff -- Notification entries are not appended unless a replace is used https://bugs.launchpad.net/bugs/337394 You received this bug notification because you are a member of Notify OSD Developers, which is subscribed to Notify OSD. Status in Notify OSD: Confirmed Bug description: Currently in the notify-osd code an append is only done if the type of update to the notification is a replace or update operation. This is incorrect and shoudl be changed to match the spec which states: "Whenever there are two or more notification bubbles in the queue that have the same title and come from the same program (as identified by its D-Bus ID), and both of them have hinted that they allow concatenation, Notify OSD should merge them into a single bubble" https://wiki.ubuntu.com/NotifyOSD#Concatenating%20existing%20bubbles The important phrasing here is "two or more notification bubbles" not an updated bubble. The reason for this is that the way that it's implemented now removes some capability from applications. The application needs to have the ability to update appended bubbles. So if I have two bubbles: a) "hello" b) "hi there" And I decide that I want to change b to "oh, goodbye", if the append hint is used, and replace is used to specify append, the result will be: hello hi there oh, goodbye When the correct result should be hello oh, goodbye This is currently how the Pidgin-libnotify plugin sends bubbles, it ensures that all messages are unique bubbles but will reuse bubbles for cases like sign on and sign off so that they get updated properly. _______________________________________________ Mailing list: https://launchpad.net/~dx-team Post to : [email protected] Unsubscribe : https://launchpad.net/~dx-team More help : https://help.launchpad.net/ListHelp
