I've included your patch in notify-osd trunk. Furthermore we also added
this suggested layout-fallback-behaviour to the notify-osd spec. A
little correction on your provided test-cases. The first one should
read:

notify-send "Icon" "Only" -i notification-keyboard-brightness-high -h 
string:x-canonical-private-icon-only:
(should result in an icon-only bubble with the full keyboard-brightness icon)

The second one should read:
notify-send "No" "Display" -h string:x-canonical-private-icon-only:
(should result in an summary-body bubble)

** Changed in: notify-osd
   Importance: Undecided => Low

** Changed in: notify-osd
       Status: New => In Progress

-- 
icon-only bubbles should fallback to regular bubbles if no icon data exists
https://bugs.launchpad.net/bugs/357070
You received this bug notification because you are a member of Notify
OSD Developers, which is subscribed to Notify OSD.

Status in Notify OSD: In Progress

Bug description:
Current design has a notification declared as icon-only that does not have 
icon-data is not displayed at all. I think such bubbles should instead fallback 
to a normal notification layout, rather than ignoring the notification in its 
entirety. This would probably be what would be shown by other galago compliant 
notification systems which do not listen for x-canonical-private-icon-only.

Steps to reproduce:
1) run `notify-send "Icon" "Only" -i notification-keyboard-brightness -h 
string:x-canonical-private-icon-only:`
2) run `notify-send "No" "Display" -h string:x-canonical-private-icon-only:`

_______________________________________________
Mailing list: https://launchpad.net/~dx-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~dx-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to