This simply frees all the returned values from
defaults_get_text_font_face. It seems like it is the only function that
gets called externally that allocates memory.

** Attachment added: "Fix option 2"
   http://launchpadlibrarian.net/25826395/g_object_get2.patch

-- 
gchar* defaults_get_ allocates memory that is almost never freed
https://bugs.launchpad.net/bugs/356956
You received this bug notification because you are a member of Notify
OSD Developers, which is subscribed to Notify OSD.

Status in Notify OSD: In Progress

Bug description:
The functions below utilize g_object_get to retrieve a gchar* property. The 
returned property is a new string that must be freed, it almost never is. I 
started working on a patch to modify bubble.c to free strings, but it became 
very extensive, I think perhaps you guys might want to consider minor 
implementation changes :)

The list of functions:

defaults_get_bubble_shadow_color
defaults_get_bubble_bg_color
defaults_get_bubble_bg_opacity
defaults_get_bubble_hover_opacity
defaults_get_content_shadow_color
defaults_get_text_font_face
defaults_get_text_title_color
defaults_get_text_body_color

_______________________________________________
Mailing list: https://launchpad.net/~dx-team
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~dx-team
More help   : https://help.launchpad.net/ListHelp

Reply via email to