the setBgColor was an example.. checking that color was really needed for
NS4, otherwise in some cases it will use a default color (I remember a nice
green :) . so that was just an example of a strange bugfix, the code looks
wrong and unneeded, but it does fix things.
Pascal Bestebroer ([EMAIL PROTECTED])
Software ontwikkelaar
Oberon Informatiesystemen b.v.
http://www.oibv.com
> -----Oorspronkelijk bericht-----
> Van: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED]]Namens Michael
> Pemberton
> Verzonden: dinsdag 27 februari 2001 13:07
> Aan: [EMAIL PROTECTED]
> Onderwerp: Re: [Dynapi-Dev] More minor glitches
>
>
> I only cleaned up the color code. there was no need checking
> for a null value
> twice.
>
> the load event stuff just stops the the browser from
> triggering the event. if
> the browser doesn't have the event captured, doesn't it stop
> the browser from
> triggering it?
>
> As for 'weird' changes, these are the same changes I've been
> making to the
> dynalyer everytime I doesn't a new version from CVS.
>
> Pascal wrote:
>
> > I noticed a few things you "removed" (the onload trapping
> for example). You
> > should take care when doing these changes to the dynlayer,
> many weird pieces
> > of code were added with a reason (most likely strange bug fixes)
> >
> > One of those things is the setBgColor that contains a
> weird NS bugfix (if
> > color==null color=nul).. I noticed it had been removed a
> few times (and I
> > simply put it back in :) because even thought the code
> looks strange, it
> > might actually be a real bug fix.
> >
> > I don't know about the onload code of a layer, but it might
> be added for
> > correct mouse event capturing, or for loadpanels or something.
> >
> > Can't remember who ever added it, but my guess is Dan
> (usually these things
> > are his :)
> >
> > Pascal Bestebroer ([EMAIL PROTECTED])
> > Software ontwikkelaar
> > Oberon Informatiesystemen b.v.
> > http://www.oibv.com
> >
> > > -----Oorspronkelijk bericht-----
> > > Van: [EMAIL PROTECTED]
> > > [mailto:[EMAIL PROTECTED]]Namens Michael
> > > Pemberton
> > > Verzonden: dinsdag 27 februari 2001 2:02
> > > Aan: [EMAIL PROTECTED]
> > > Onderwerp: Re: [Dynapi-Dev] More minor glitches
> > >
> > >
> > > I've attached a version that I have cleaned up and commented with
> > > possible changes.
> > >
> > > I'd also suggest that the setStyle() method be changed to an
> > > ext/layer.js
> > > method as I'm still to see any code that uses it.
> > >
> >
> > _______________________________________________
> > Dynapi-Dev mailing list
> > [EMAIL PROTECTED]
> > http://lists.sourceforge.net/lists/listinfo/dynapi-dev
>
> --
> Michael Pemberton
> [EMAIL PROTECTED]
> ICQ: 12107010
>
>
>
>
> _______________________________________________
> Dynapi-Dev mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
>
_______________________________________________
Dynapi-Dev mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/dynapi-dev
