It means that the code is more readable. As it is at the moment, there are too
many checks inside methods. I think that it is better to minimise such browser
checks. For example, we currently check for NS4 and skip the execution of
findDimensions, simple to execute it at another point in the ns4 specific
method. The version I suggest is for more readable and reduces the complexity
if anything.
It seems to come back to the problem of the first working solution being thought
of as being the best. But I don't think we need start another rock thowing
contest at this point in time. : )
Robert Rainwater wrote:
> If there aren't any children of the DynDocument, then then the loop
> will not execute. So, if there aren't any dynlayers, its not going to
> increase any execution time. But with your changes I don't see how that
> would do anything but add complexity.
>
> --
> Robert Rainwater
>
> On 6/8/2001, 9:25:14 PM EST, Michael wrote about "[Dynapi-Dev] DynAPI 2.54":
>
> > I suggest the following changes with regard to the resize fix.
>
> > In dyndocument.js, place a resize handler that is to be executed by ALL
> > browsers. this will consist of just:
> > DynDocument.prototype.resizeHandler=function() {
> > this.findDimensions(); };
>
> > Then, in dynlayer.js, test for ns4 and override this method with the
> > fixed resize method.
>
> > This is because the resize fix is not required unless layers are in
> > use. This will make it simpler for those who may have a document that
> > only uses the dyndocument features without the use of dynlayers.
>
> > Robert Rainwater wrote:
>
> >> In getting ready for the next release, please test the following
> >> snapshot:
> >> http://dynapi.sourceforge.net/snapshot/src/dynapi_2001_06_08.zip
> >>
> >> I believe the NS resize fix could use plenty of testing. So if you
> >> find a bug, please reply.
> >>
> >> Here are the other fixes to test:
> >> - setID should now remove old references if calling setID more than
> >> once.
> >> - Recycled layers should not retain their old properties in NS4
> >> (bgColor, bgImage, etc)
> >> - Scrollpane fix (bw and bh were set incorrectly)
> >> - handleEvent fix for NS4 in mouse.js (should now pass the right
> >> parameters)
> >> - NS resize fix
> >> - Anything else?
> >>
> >> --
> >> Robert Rainwater
> >>
> >> _______________________________________________
> >> Dynapi-Dev mailing list
> >> [EMAIL PROTECTED]
> >> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
>
> > --
> > Michael Pemberton
> > [EMAIL PROTECTED]
> > ICQ: 12107010
>
> > _______________________________________________
> > Dynapi-Dev mailing list
> > [EMAIL PROTECTED]
> > http://lists.sourceforge.net/lists/listinfo/dynapi-dev
>
> _______________________________________________
> Dynapi-Dev mailing list
> [EMAIL PROTECTED]
> http://lists.sourceforge.net/lists/listinfo/dynapi-dev
--
Michael Pemberton
[EMAIL PROTECTED]
ICQ: 12107010
_______________________________________________
Dynapi-Dev mailing list
[EMAIL PROTECTED]
http://lists.sourceforge.net/lists/listinfo/dynapi-dev
