Hi Daniel,
The PanelBar and Stacker Class looks very good!
I think it's a very cool widget indeed! Using stacker
a programmer can easily create something like the
Micrsoft Outlook Bar.
I just have a few things to say concerning the
PanelBar widget:
1) IMO I don't think the lyrMenu agrument should be
inside the constructor. This method will require the
user to create both a menu and a content area. It's
simpler to give them a default menu and allow them to
change it later:
var pb = new PanelBar(content)
...
// (Optional) here the user can change the menu
pb.setMenuContent(new DynLayer());
Another thing that I try to do when creating widgets
is to arrange my arguments in such a manner that most
frequently used arguments appears first. IMO I would
arrange the contructor agruments like this:
PanelBar(lyrcnt,x,y,w,h,minimized,mnuheight)
The "mnucss" "cntcss" can be set by the user so I
don't see these as necessary inside the constructor:
var content = new DynLayer();
content.setClass('content_class'); // user sets the
class here
pb.setContent(content);
....
var menu = new DynLayer();
menu.setClass('menu_class'); // user sets the class
here
pb.setMenuContent(menu);
2) Whenever the panel is minimized or maximized the
menu.setHTML() function is call throughout the entire
animation loop. This should be avoided.
3) It would also be nice to provide an function to
turn on or off the animation.
example:
pb.setAnimated(false);
4) It would be nice if the widget could trigger a
minimize and maximized event when the appropiate
button is pressed.
5) Change line 54 to read:
var p = dynapi.setPrototype('PanelBar','DynLayer');
By doing this a programmer and take advantage of the
isClass() and getClass() functions
6) I don't think setDraging() is necessary since the
user can call the setDragEnabled function when
DragEvent is included
best regards,
--
Raymond Irving
--- Daniel Tiru <[EMAIL PROTECTED]> wrote:
> + Renamed window to PanelBar
> - PanelBar: removed function setdragable
> + PanelBar: Renamed minimizewindow to minimize
> + PanelBar: Renamed maximizewindow to maximize
> + Stacker: Added missed Semicolons
> + Updated quickref and examples for PanelBar and
> Stacker
>
> Regards
> Daniel
>
>
>
>
>
-------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Welcome to geek heaven.
> http://thinkgeek.com/sf
> _______________________________________________
> Dynapi-Dev mailing list
> [EMAIL PROTECTED]
>
http://www.mail-archive.com/[EMAIL PROTECTED]/
__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Dynapi-Dev mailing list
[EMAIL PROTECTED]
http://www.mail-archive.com/[EMAIL PROTECTED]/
