Branch: refs/heads/thaines/refactor_symtab_getOrCreateModule Home: https://github.com/dyninst/dyninst Commit: e7a98a179ae4413877ecd6ab1554eed3b9c0d6a0 https://github.com/dyninst/dyninst/commit/e7a98a179ae4413877ecd6ab1554eed3b9c0d6a0 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023)
Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Merge getOrCreateModule and newModule The latter was only ever called from the former. Commit: c42392456eaaa751990a1d3872209d4b61010602 https://github.com/dyninst/dyninst/commit/c42392456eaaa751990a1d3872209d4b61010602 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Remove dead debug code Commit: 302f77d6228b9755aadea7ff59bffe4add874795 https://github.com/dyninst/dyninst/commit/302f77d6228b9755aadea7ff59bffe4add874795 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Do not adjust Module's address It's unclear why this was here. This function is currently called from only two places: BinaryEdit::writeFile and Object::fix_global_symbol_modules_static_dwarf. In the first, the module created is called 'dyninstInst'. This is the only place where that name is used, so only one module would be created. Moreover, 'writeFile' will only produce a single binary output, so there wouldn't be multiple modules. In the second, the module lookup will always fail because we are creating new ones for each DWARF compilation unit (CU), and those are guaranteed to be unique as we iterate over the results of 'dwarf_nextcu'. Commit: b3f0193caced247f8092365006507c3622f36118 https://github.com/dyninst/dyninst/commit/b3f0193caced247f8092365006507c3622f36118 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Remove 'directory definitions' check This kind of name is never used manually anywhere in Dyninst and the names that come from DWARF compilation units (CUs) are never directories. Commit: 2e5592a576b5ab581415215e98888efc0e54ed1f https://github.com/dyninst/dyninst/commit/2e5592a576b5ab581415215e98888efc0e54ed1f Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Clean up 'create' tracing message Commit: 78e466428ba0b69607ac89ca003b46e0fd041c62 https://github.com/dyninst/dyninst/commit/78e466428ba0b69607ac89ca003b46e0fd041c62 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Tidy up variable declarations. Commit: a6471b9e923cbc8521b00e5c697d88b16373836e https://github.com/dyninst/dyninst/commit/a6471b9e923cbc8521b00e5c697d88b16373836e Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Remove 'assert' after 'new'. We require exceptions to be enabled when building Dyninst and we aren't using the 'nothrow' version of 'operator new' here. This check is useless. Commit: 2d4c085ae4bfe45fe6947b3f40a4179143b6d36f https://github.com/dyninst/dyninst/commit/2d4c085ae4bfe45fe6947b3f40a4179143b6d36f Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Remove existence check. This will never be true because 'findModuleByOffset' would have found the module. Commit: 1970192fd3f41954543607257d369e0c53f7c198 https://github.com/dyninst/dyninst/commit/1970192fd3f41954543607257d369e0c53f7c198 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Don't return with parens Commit: 04f0160705092eae99f5e1d7e4b86a00628549a1 https://github.com/dyninst/dyninst/commit/04f0160705092eae99f5e1d7e4b86a00628549a1 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- Rename 'ret' to 'mod'. For clarity. Commit: 165f6a7ad0061c905c1391d74cb28a06d154e468 https://github.com/dyninst/dyninst/commit/165f6a7ad0061c905c1391d74cb28a06d154e468 Author: Tim Haines <thaines.as...@gmail.com> Date: 2023-10-08 (Sun, 08 Oct 2023) Changed paths: M symtabAPI/src/Symtab.C Log Message: ----------- REBASE ME: fix message Compare: https://github.com/dyninst/dyninst/compare/e7a98a179ae4%5E...165f6a7ad006 _______________________________________________ Dyninst-api mailing list Dyninst-api@cs.wisc.edu https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api