Branch: refs/heads/thaines/cleanup_AstNode
Home: https://github.com/dyninst/dyninst
Commit: 4d6f48fec5e4178aacb41d4871d2acd477a66629
https://github.com/dyninst/dyninst/commit/4d6f48fec5e4178aacb41d4871d2acd477a66629
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove deepCopy
It was added by 21d1427b9 in 2010, but never used.
Commit: 23b7cde2666b782f4a293536903eab6f5a6e9011
https://github.com/dyninst/dyninst/commit/23b7cde2666b782f4a293536903eab6f5a6e9011
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove Dyn_C error reporting variables
These were only used in the deepCopy member functions.
Commit: a525081d329071b4b9d7e120b84c7e7c9a4cf00c
https://github.com/dyninst/dyninst/commit/a525081d329071b4b9d7e120b84c7e7c9a4cf00c
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove nodeType
Its usage was removed by 20116a1026 in 2006
Commit: 710f908c4d336f253021edd1cf36f1cd9d419b4c
https://github.com/dyninst/dyninst/commit/710f908c4d336f253021edd1cf36f1cd9d419b4c
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove cleanRegTracker
This was added by 123a8c7f31 in 2010, but never implemented.
Commit: bd207f603410ba24bea604c591378595fd1a4f37
https://github.com/dyninst/dyninst/commit/bd207f603410ba24bea604c591378595fd1a4f37
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
M dyninstAPI/src/baseTramp.h
Log Message:
-----------
Move cfjRet_t into baseTramp
This is the only place it's used.
Commit: 5267fda558ad20cbd62abc8cf00278a9aee02949
https://github.com/dyninst/dyninst/commit/5267fda558ad20cbd62abc8cf00278a9aee02949
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove dataReqNode declaration
It's never used.
Commit: f8152b330b43f6035bc27c8747d0ee010039cae6
https://github.com/dyninst/dyninst/commit/f8152b330b43f6035bc27c8747d0ee010039cae6
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/CMakeLists.txt
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
M dyninstAPI/src/codegen.h
A dyninstAPI/src/regTracker.C
A dyninstAPI/src/regTracker.h
Log Message:
-----------
Extract regTracker_t
I'm suspicious of the gymanastics in AstNode::generateCode, but
I'll leave it as-is for now.
Commit: 758a19015b854867dca7022ebe764137468dafd7
https://github.com/dyninst/dyninst/commit/758a19015b854867dca7022ebe764137468dafd7
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove 'void' parameter
This isn't legal c++.
Commit: 3cadc9b72c9ab561d1ee8a58f461949c8c67c76f
https://github.com/dyninst/dyninst/commit/3cadc9b72c9ab561d1ee8a58f461949c8c67c76f
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove checkUseCount
Its usage was removed by 123a8c7f in 2006.
Commit: c28c20430c1c757e4aebeeecdc0a7c4943b8ac8c
https://github.com/dyninst/dyninst/commit/c28c20430c1c757e4aebeeecdc0a7c4943b8ac8c
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove printUserCount
Its usage was removed by 123a8c7f3 in 2006.
Commit: d2434104f155b2946b2f2d1cd614f54e918b45a4
https://github.com/dyninst/dyninst/commit/d2434104f155b2946b2f2d1cd614f54e918b45a4
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode::getArgs
It was added by 21d1427b9 in 2010, but never used.
Commit: e2ba0b480a4696fa71d7af39bedc397c275d9c64
https://github.com/dyninst/dyninst/commit/e2ba0b480a4696fa71d7af39bedc397c275d9c64
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove setChildren
Added by 48fb32bc23 in 2010
Used in AST::Ptr AST::substitute(AST::Ptr in, AST::Ptr a, AST::Ptr b)
Usage removed by 807e320e334c in 2010.
Current implementation was added by 21d1427b92be10 in 2010, but no call
to it was added.
Commit: f4723c52adfca3415221eccf47ae4ea2e37fdf0c
https://github.com/dyninst/dyninst/commit/f4723c52adfca3415221eccf47ae4ea2e37fdf0c
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide a default for canBeKept
Commit: 6944461fdd7875330921be799e91aa658ba86ecb
https://github.com/dyninst/dyninst/commit/6944461fdd7875330921be799e91aa658ba86ecb
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove stealRegister
It was added by 0380c4db951 in 2006, but never implemented.
Commit: f0dae736f3b35047ed379162dd7ed421ebf363ff
https://github.com/dyninst/dyninst/commit/f0dae736f3b35047ed379162dd7ed421ebf363ff
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove subpath
Its usage and definition were removed by 123a8c7f31 in 2006.
Commit: 577678022ec38ae0ba8dde2be623078b91e9f82b
https://github.com/dyninst/dyninst/commit/577678022ec38ae0ba8dde2be623078b91e9f82b
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Move children into AstNode
This simplifies the implementations.
Commit: f8b86c0a539ad64ff4706688ff9883f78f7598da
https://github.com/dyninst/dyninst/commit/f8b86c0a539ad64ff4706688ff9883f78f7598da
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode(AstNodePtr)
Its original implementation 'AstNode(AstNode *src)' was removed by
5dabf3ca8b1 in 2006. The interface was changed to its current form by
e7c183b934 in 2007, but was never re-implemented.
Commit: 4d786a66b2694ad80fccf62a158cc060efbdd925
https://github.com/dyninst/dyninst/commit/4d786a66b2694ad80fccf62a158cc060efbdd925
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode::getTreeSize
It was added by 97dc86ee3f0 in 2006, but never used.
Commit: 4cb5991858e4c018d63c3639d6103e7026e16b25
https://github.com/dyninst/dyninst/commit/4cb5991858e4c018d63c3639d6103e7026e16b25
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove accessesParam
Its usage was removed by 47c4dfe96 in 2010.
Commit: 7d421e119dc05966f8d163a236fbce61d8583b6a
https://github.com/dyninst/dyninst/commit/7d421e119dc05966f8d163a236fbce61d8583b6a
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide default for containsFuncCall
For AstCallNode, this is only safe because its child nodes are
only added to AstNode::children in the AstCallNode ctor if they exist.
Commit: 5ae061f299f5fd51ef36123483614f10d10282fb
https://github.com/dyninst/dyninst/commit/5ae061f299f5fd51ef36123483614f10d10282fb
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide a default for setVariableAST
For AstOperatorNode, AstOperandNode, AstCallNode, and AstSequenceNode,
this is only safe because its child nodes are only added to
AstNode::children in their respecitive ctor if the children exist.
Commit: 4eb42ad2c3816eb60483b2126868ad99ef71ccba
https://github.com/dyninst/dyninst/commit/4eb42ad2c3816eb60483b2126868ad99ef71ccba
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide a default for usesAppRegister
Commit: 60d1a79fc386ef0a648065f00230d7df5910bbcf
https://github.com/dyninst/dyninst/commit/60d1a79fc386ef0a648065f00230d7df5910bbcf
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Require generateCode_phase2
All of the ASTs already implement it. This also converts the runtime check
into a compile-time one.
Commit: 58c1b1c20e4f2d5c5e1b8045a1cbcc362f18cc7f
https://github.com/dyninst/dyninst/commit/58c1b1c20e4f2d5c5e1b8045a1cbcc362f18cc7f
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
AstNode: use in-class member initializers
Commit: 53d1d3cdf7aae464d3d24b1d2cb435dacebcc810
https://github.com/dyninst/dyninst/commit/53d1d3cdf7aae464d3d24b1d2cb435dacebcc810
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
AstNode: use default dtor
Commit: 2597890fe9993eaae75f96b93dc64d74157e9528
https://github.com/dyninst/dyninst/commit/2597890fe9993eaae75f96b93dc64d74157e9528
Author: Tim Haines <[email protected]>
Date: 2026-01-21 (Wed, 21 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
AstNode: inline getType
Compare: https://github.com/dyninst/dyninst/compare/6609ba17b8ff...2597890fe999
To unsubscribe from these emails, change your notification settings at
https://github.com/dyninst/dyninst/settings/notifications
_______________________________________________
Dyninst-api mailing list
[email protected]
https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api
