Branch: refs/heads/thaines/cleanup_AstNode
Home: https://github.com/dyninst/dyninst
Commit: a963408706b072db184c3cd122216f6499e14be6
https://github.com/dyninst/dyninst/commit/a963408706b072db184c3cd122216f6499e14be6
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove deepCopy
It was added by 21d1427b9 in 2010, but never used.
Commit: 44d5772113330ab7b931e7faaaab04f405f75e69
https://github.com/dyninst/dyninst/commit/44d5772113330ab7b931e7faaaab04f405f75e69
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove Dyn_C error reporting variables
These were only used in the deepCopy member functions.
Commit: ed33dd0ae6630136f0d0f3d65ec3712f07d21a24
https://github.com/dyninst/dyninst/commit/ed33dd0ae6630136f0d0f3d65ec3712f07d21a24
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove nodeType
Its usage was removed by 20116a1026 in 2006
Commit: 03a543cd330ab4e794ef211514a2fb917ecf2317
https://github.com/dyninst/dyninst/commit/03a543cd330ab4e794ef211514a2fb917ecf2317
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove cleanRegTracker
This was added by 123a8c7f31 in 2010, but never implemented.
Commit: 3da6eac7255fd4e2f331a5790d3df066af15a42d
https://github.com/dyninst/dyninst/commit/3da6eac7255fd4e2f331a5790d3df066af15a42d
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
M dyninstAPI/src/baseTramp.h
Log Message:
-----------
Move cfjRet_t into baseTramp
This is the only place it's used.
Commit: 126496162f27f2a554fcd65c8f5ae2379a1905ee
https://github.com/dyninst/dyninst/commit/126496162f27f2a554fcd65c8f5ae2379a1905ee
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove dataReqNode declaration
It's never used.
Commit: 5b45f254c167161ab512a059b05140e3743453ad
https://github.com/dyninst/dyninst/commit/5b45f254c167161ab512a059b05140e3743453ad
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/CMakeLists.txt
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
M dyninstAPI/src/codegen.h
A dyninstAPI/src/regTracker.C
A dyninstAPI/src/regTracker.h
Log Message:
-----------
Extract regTracker_t
I'm suspicious of the gymanastics in AstNode::generateCode, but
I'll leave it as-is for now.
Commit: 4aa44f007488ae4bd8cdd9ff0f17d0dbfb5c3bf2
https://github.com/dyninst/dyninst/commit/4aa44f007488ae4bd8cdd9ff0f17d0dbfb5c3bf2
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove 'void' parameter
This isn't legal c++.
Commit: 5e196d59749599eff6373f78fb311dee401539fa
https://github.com/dyninst/dyninst/commit/5e196d59749599eff6373f78fb311dee401539fa
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove checkUseCount
Its usage was removed by 123a8c7f in 2006.
Commit: ce23f776c1f1a3bd6f358c3137a6e57a56a003ba
https://github.com/dyninst/dyninst/commit/ce23f776c1f1a3bd6f358c3137a6e57a56a003ba
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove printUserCount
Its usage was removed by 123a8c7f3 in 2006.
Commit: 1cd9c598dbbd777fe5348e2797e88f478bcc35a3
https://github.com/dyninst/dyninst/commit/1cd9c598dbbd777fe5348e2797e88f478bcc35a3
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode::getArgs
It was added by 21d1427b9 in 2010, but never used.
Commit: 1369ac12a0c646440267e2a71331fc402e92ee3f
https://github.com/dyninst/dyninst/commit/1369ac12a0c646440267e2a71331fc402e92ee3f
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove setChildren
Added by 48fb32bc23 in 2010
Used in AST::Ptr AST::substitute(AST::Ptr in, AST::Ptr a, AST::Ptr b)
Usage removed by 807e320e334c in 2010.
Current implementation was added by 21d1427b92be10 in 2010, but no call
to it was added.
Commit: 6f15cd712b064954fc51c13c3f61758ad1972173
https://github.com/dyninst/dyninst/commit/6f15cd712b064954fc51c13c3f61758ad1972173
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide a default for canBeKept
Commit: 4bd6a4c2fbb6f0b23a5c1be1e594e372cb148751
https://github.com/dyninst/dyninst/commit/4bd6a4c2fbb6f0b23a5c1be1e594e372cb148751
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove stealRegister
It was added by 0380c4db951 in 2006, but never implemented.
Commit: 8f3241d02fffeb61e428e72b0b5be2959e320a4e
https://github.com/dyninst/dyninst/commit/8f3241d02fffeb61e428e72b0b5be2959e320a4e
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove subpath
Its usage and definition were removed by 123a8c7f31 in 2006.
Commit: 79a8bc42919a99f8a5a24a518fcdec795416a87d
https://github.com/dyninst/dyninst/commit/79a8bc42919a99f8a5a24a518fcdec795416a87d
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Move children into AstNode
This simplifies the implementations.
Commit: b0db6e0db38fe8d1c15a5e3c253bb61621854bed
https://github.com/dyninst/dyninst/commit/b0db6e0db38fe8d1c15a5e3c253bb61621854bed
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode(AstNodePtr)
Its original implementation 'AstNode(AstNode *src)' was removed by
5dabf3ca8b1 in 2006. The interface was changed to its current form by
e7c183b934 in 2007, but was never re-implemented.
Commit: da5017d71b7ff8b09d4be7ca7fb556e51ad7ea56
https://github.com/dyninst/dyninst/commit/da5017d71b7ff8b09d4be7ca7fb556e51ad7ea56
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode::getTreeSize
It was added by 97dc86ee3f0 in 2006, but never used.
Commit: 511999d2f40a957db2947bc3b02b4515a4191bc3
https://github.com/dyninst/dyninst/commit/511999d2f40a957db2947bc3b02b4515a4191bc3
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove accessesParam
Its usage was removed by 47c4dfe96 in 2010.
Commit: c7dcaad3f24a10c83e112910bc727a74c53ba0df
https://github.com/dyninst/dyninst/commit/c7dcaad3f24a10c83e112910bc727a74c53ba0df
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide default for containsFuncCall
For AstCallNode, this is only safe because its child nodes are
only added to AstNode::children in the AstCallNode ctor if they exist.
Commit: 3c373c707cfb96d471274446dfe00e6a793a1cae
https://github.com/dyninst/dyninst/commit/3c373c707cfb96d471274446dfe00e6a793a1cae
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide a default for setVariableAST
For AstOperatorNode, AstOperandNode, AstCallNode, and AstSequenceNode,
this is only safe because its child nodes are only added to
AstNode::children in their respecitive ctor if the children exist.
Commit: 86d6ae8ab214cb3614145947738584a009e0e341
https://github.com/dyninst/dyninst/commit/86d6ae8ab214cb3614145947738584a009e0e341
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Provide a default for usesAppRegister
Commit: 6845c2093d5a0c0555a1ad6c19e3eb20eb6b7d5a
https://github.com/dyninst/dyninst/commit/6845c2093d5a0c0555a1ad6c19e3eb20eb6b7d5a
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Require generateCode_phase2
All of the ASTs already implement it. This also converts the runtime check
into a compile-time one.
Commit: e4dab00e9bdfdc9efb6ed7ad24e2e4c0375a6f80
https://github.com/dyninst/dyninst/commit/e4dab00e9bdfdc9efb6ed7ad24e2e4c0375a6f80
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
AstNode: use in-class member initializers
Commit: fc8e21a840f0aa3ae43e25627f74fbe00668a90a
https://github.com/dyninst/dyninst/commit/fc8e21a840f0aa3ae43e25627f74fbe00668a90a
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
AstNode: use default dtor
Commit: 6f18ea5c6516e82724800bd56339fcc503980753
https://github.com/dyninst/dyninst/commit/6f18ea5c6516e82724800bd56339fcc503980753
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
AstNode: inline getType
Commit: 8889d69c4a00686be69fbef310878906b8d28884
https://github.com/dyninst/dyninst/commit/8889d69c4a00686be69fbef310878906b8d28884
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove AstNode::labelNode(std::string)
This should have been removed by eac8cf2c8.
Commit: 4ad2894fb9ce1d1b950535a701214899be83c4b2
https://github.com/dyninst/dyninst/commit/4ad2894fb9ce1d1b950535a701214899be83c4b2
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/CMakeLists.txt
A dyninstAPI/src/ASTs/OperandType.h
M dyninstAPI/src/BPatch_addressSpace.C
M dyninstAPI/src/BPatch_function.C
M dyninstAPI/src/BPatch_snippet.C
M dyninstAPI/src/IAPI_to_AST.C
M dyninstAPI/src/addressSpace.C
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
M dyninstAPI/src/dynProcess.C
M dyninstAPI/src/inst-aarch64.C
M dyninstAPI/src/inst-power.C
M dyninstAPI/src/inst-x86.C
M dyninstAPI/src/linux-x86.C
M dyninstAPI/src/syscallNotification.C
Log Message:
-----------
Extract operandType
This centralizes the type and its functions and will help with
possibly refactoring the operand-specific methods out of AstNode
some day.
Commit: ce50b8617ff30f98b424d56a0b4c130f681d1fb0
https://github.com/dyninst/dyninst/commit/ce50b8617ff30f98b424d56a0b4c130f681d1fb0
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ASTs/OperandType.h
M dyninstAPI/src/ast.C
Log Message:
-----------
Remove operandType::DataReg
Its only usage was in BPatch_regExpr that was was deprecated by 4d15de8
in 2008 and removed by f4ee3410b in 2020.
Commit: 1107bbced73f71ee51250b90de701b42d176cc7b
https://github.com/dyninst/dyninst/commit/1107bbced73f71ee51250b90de701b42d176cc7b
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
Log Message:
-----------
Use simpler, faster isPowerOf2 in ast.C
Commit: dbd75fdd0ca3b1abf77801a7eb506ddb6f10d83a
https://github.com/dyninst/dyninst/commit/dbd75fdd0ca3b1abf77801a7eb506ddb6f10d83a
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/inst.h
Log Message:
-----------
Move isPowerOf2(int,int&) into inst.h
This is the only place it's used now.
Commit: 5c2a7f69f27aa6bcf3e4cae5c63f856527ec3e7c
https://github.com/dyninst/dyninst/commit/5c2a7f69f27aa6bcf3e4cae5c63f856527ec3e7c
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
M dyninstAPI/src/opcode.h
Log Message:
-----------
Extract AstNode::format(opCode) into opcode.h
Commit: 66a7a16b786fa74f6bde4da7b73530e87b7ed732
https://github.com/dyninst/dyninst/commit/66a7a16b786fa74f6bde4da7b73530e87b7ed732
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/inst.h
Log Message:
-----------
Remove unneeded include of 'opcode.h'
Commit: 6c2487c0f25cb3fea2bda833bbe5872ca1b64ff9
https://github.com/dyninst/dyninst/commit/6c2487c0f25cb3fea2bda833bbe5872ca1b64ff9
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
M dyninstAPI/src/registerSpace.h
Log Message:
-----------
Move declaration of emitLoadPreviousStackFrameRegister to registerSpace
This is the only place it's used.
Commit: 5822528af7bbc15fa276610e5b0a964955d1ba3a
https://github.com/dyninst/dyninst/commit/5822528af7bbc15fa276610e5b0a964955d1ba3a
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Remove SCAST_AST macro
It's no longer used.
Commit: 8f4c1171b8a5134cd6d7e753998d85cc3a0dfae2
https://github.com/dyninst/dyninst/commit/8f4c1171b8a5134cd6d7e753998d85cc3a0dfae2
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
M dyninstAPI/src/baseTramp.C
Log Message:
-----------
Move DCAST_AST to baseTramp.C
That's the only place it's used.
Commit: fd92d4d95f314198636843fa2cc78d589aace83c
https://github.com/dyninst/dyninst/commit/fd92d4d95f314198636843fa2cc78d589aace83c
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.h
Log Message:
-----------
Clean up comments
Commit: 05576637ef05b8ad3994d3861d7a271d4b7d5ba2
https://github.com/dyninst/dyninst/commit/05576637ef05b8ad3994d3861d7a271d4b7d5ba2
Author: Tim Haines <[email protected]>
Date: 2026-01-24 (Sat, 24 Jan 2026)
Changed paths:
M dyninstAPI/src/ast.C
M dyninstAPI/src/ast.h
Log Message:
-----------
Clean up includes
Compare: https://github.com/dyninst/dyninst/compare/2597890fe999...05576637ef05
To unsubscribe from these emails, change your notification settings at
https://github.com/dyninst/dyninst/settings/notifications
_______________________________________________
Dyninst-api mailing list
[email protected]
https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api
