[DynInst_API:] [dyninst/dyninst] b907a1: Split up dyninstAPI AST node classes (#2125)

Tim Haines via Dyninst-api Thu, 26 Feb 2026 16:14:37 -0800

  Branch: refs/heads/thaines/remove_parRegion
  Home:   https://github.com/dyninst/dyninst
  Commit: b907a157c20ef5587581ceda54be4aa664ae7206
      
https://github.com/dyninst/dyninst/commit/b907a157c20ef5587581ceda54be4aa664ae7206
  Author: Tim Haines <[email protected]>
  Date:   2026-02-26 (Thu, 26 Feb 2026)


  Changed paths:
    M dyninstAPI/CMakeLists.txt
    M dyninstAPI/h/BPatch_addressSpace.h
    M dyninstAPI/h/BPatch_binaryEdit.h
    M dyninstAPI/h/BPatch_process.h
    M dyninstAPI/h/BPatch_snippet.h
    A dyninstAPI/src/ASTs/AmdgpuEpilogue.C
    A dyninstAPI/src/ASTs/AmdgpuEpilogue.h
    A dyninstAPI/src/ASTs/AmdgpuPrologue.C
    A dyninstAPI/src/ASTs/AmdgpuPrologue.h
    A dyninstAPI/src/ASTs/OperandType.h
    A dyninstAPI/src/ASTs/actualAddressAST.C
    A dyninstAPI/src/ASTs/addressAST.h
    A dyninstAPI/src/ASTs/ast.h
    A dyninstAPI/src/ASTs/ast_helpers.h
    A dyninstAPI/src/ASTs/atomicOperationAST.C
    A dyninstAPI/src/ASTs/atomicOperationAST.h
    A dyninstAPI/src/ASTs/codeGenAST.C
    A dyninstAPI/src/ASTs/codeGenAST.h
    A dyninstAPI/src/ASTs/functionCallAST.C
    A dyninstAPI/src/ASTs/functionCallAST.h
    A dyninstAPI/src/ASTs/genericStackAST.C
    A dyninstAPI/src/ASTs/genericStackAST.h
    A dyninstAPI/src/ASTs/jumpTargetAST.C
    A dyninstAPI/src/ASTs/jumpTargetAST.h
    A dyninstAPI/src/ASTs/memoryAccessAST.C
    A dyninstAPI/src/ASTs/memoryAccessAST.h
    A dyninstAPI/src/ASTs/nullAST.C
    A dyninstAPI/src/ASTs/nullAST.h
    A dyninstAPI/src/ASTs/operandAST.C
    A dyninstAPI/src/ASTs/operandAST.h
    A dyninstAPI/src/ASTs/operatorAST.C
    A dyninstAPI/src/ASTs/operatorAST.h
    A dyninstAPI/src/ASTs/originalAddressAST.C
    A dyninstAPI/src/ASTs/scrambleRegistersAST.C
    A dyninstAPI/src/ASTs/scrambleRegistersAST.h
    A dyninstAPI/src/ASTs/sequenceAST.C
    A dyninstAPI/src/ASTs/sequenceAST.h
    A dyninstAPI/src/ASTs/snippetAST.C
    A dyninstAPI/src/ASTs/snippetAST.h
    A dyninstAPI/src/ASTs/stackAST.C
    A dyninstAPI/src/ASTs/stackAST.h
    A dyninstAPI/src/ASTs/stackInsertionAST.C
    A dyninstAPI/src/ASTs/stackInsertionAST.h
    A dyninstAPI/src/ASTs/stackRemovalAST.C
    A dyninstAPI/src/ASTs/stackRemovalAST.h
    A dyninstAPI/src/ASTs/threadAST.C
    A dyninstAPI/src/ASTs/threadAST.h
    A dyninstAPI/src/ASTs/variableAST.C
    A dyninstAPI/src/ASTs/variableAST.h
    R dyninstAPI/src/AmdgpuEpilogue.C
    R dyninstAPI/src/AmdgpuEpilogue.h
    M dyninstAPI/src/AmdgpuPointHandler.C
    M dyninstAPI/src/AmdgpuPointHandler.h
    R dyninstAPI/src/AmdgpuPrologue.C
    R dyninstAPI/src/AmdgpuPrologue.h
    M dyninstAPI/src/BPatch_addressSpace.C
    M dyninstAPI/src/BPatch_binaryEdit.C
    M dyninstAPI/src/BPatch_function.C
    M dyninstAPI/src/BPatch_point.C
    M dyninstAPI/src/BPatch_snippet.C
    M dyninstAPI/src/IAPI_to_AST.C
    M dyninstAPI/src/IAPI_to_AST.h
    R dyninstAPI/src/OperandType.h
    M dyninstAPI/src/PointHandler.h
    M dyninstAPI/src/Relocation/DynInstrumenter.C
    M dyninstAPI/src/Relocation/DynInstrumenter.h
    M dyninstAPI/src/StackMod/StackModExpr.C
    M dyninstAPI/src/addressSpace.C
    M dyninstAPI/src/addressSpace.h
    R dyninstAPI/src/ast.C
    R dyninstAPI/src/ast.h
    M dyninstAPI/src/codegen.h
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/dynProcess.h
    M dyninstAPI/src/emit-aarch64.h
    M dyninstAPI/src/emit-amdgpu.C
    M dyninstAPI/src/emit-amdgpu.h
    M dyninstAPI/src/emit-power.h
    M dyninstAPI/src/emit-x86.C
    M dyninstAPI/src/emit-x86.h
    M dyninstAPI/src/emitter.h
    M dyninstAPI/src/inst-aarch64.C
    M dyninstAPI/src/inst-amdgpu.C
    M dyninstAPI/src/inst-power.C
    M dyninstAPI/src/inst-power.h
    M dyninstAPI/src/inst-winnt.C
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI/src/inst.C
    M dyninstAPI/src/inst.h
    M dyninstAPI/src/instPoint.C
    M dyninstAPI/src/instPoint.h
    M dyninstAPI/src/linux-aarch64.C
    M dyninstAPI/src/linux-power.C
    M dyninstAPI/src/linux-x86.C
    M dyninstAPI/src/parse-aarch64.C
    M dyninstAPI/src/parse-power.C
    M dyninstAPI/src/parse-x86.C
    M dyninstAPI/src/pdwinnt.C
    M dyninstAPI/src/regTracker.C
    M dyninstAPI/src/regTracker.h
    M dyninstAPI/src/registerSpace/registerSpace.C
    M dyninstAPI/src/syscallNotification.C
    M dyninstAPI/src/trampolines/baseTramp.C
    M dyninstAPI/src/trampolines/baseTramp.h
    M tests/unit/dyninstAPI/emitter/amdgpu_gfx908.cpp
    M tests/unit/dyninstAPI/emitter/x86_64.cpp

  Log Message:
  -----------
  Split up dyninstAPI AST node classes (#2125)

This makes them much easier to reason about and to see where the 
architecture-specific parts are.


* Extract operandType

This centralizes the type and its functions and will help with
possibly refactoring the operand-specific methods out of AstNode
some day.

* Create a decorator for stack ASTs

Eventually MSpecialType will go in there, but it's needed for AstNode to
build right now.

* Remove ast.C

It's no longer needed.

* Move MSpecialType into AstStackNode class

This is a better logical place for it.

* Extract AstNode::threadIndexNode into a class

This makes it consistent with the other ASTs.

NOTE: I think it should override containsFuncCall to return 'true'. The
      original implementation didn't, so I've left it as-is.

Note that AstCallNode::constFunc_ is only true when dealing with an
instance of AstThreadIndexNode, so there's no reason to store it. This
also allows AstCallNode::canBeKept to be pushed down into
AstThreadIndexNode.


  Commit: 5c3865ec2ef4dd279deb87852329cac0f97b7a26
      
https://github.com/dyninst/dyninst/commit/5c3865ec2ef4dd279deb87852329cac0f97b7a26
  Author: Tim Haines <[email protected]>
  Date:   2026-02-26 (Thu, 26 Feb 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    M dyninstAPI/h/BPatch_addressSpace.h
    M dyninstAPI/h/BPatch_binaryEdit.h
    M dyninstAPI/h/BPatch_process.h
    M dyninstAPI/h/BPatch_snippet.h
    A dyninstAPI/src/ASTs/AmdgpuEpilogue.C
    A dyninstAPI/src/ASTs/AmdgpuEpilogue.h
    A dyninstAPI/src/ASTs/AmdgpuPrologue.C
    A dyninstAPI/src/ASTs/AmdgpuPrologue.h
    A dyninstAPI/src/ASTs/OperandType.h
    A dyninstAPI/src/ASTs/actualAddressAST.C
    A dyninstAPI/src/ASTs/addressAST.h
    A dyninstAPI/src/ASTs/ast.h
    A dyninstAPI/src/ASTs/ast_helpers.h
    A dyninstAPI/src/ASTs/atomicOperationAST.C
    A dyninstAPI/src/ASTs/atomicOperationAST.h
    A dyninstAPI/src/ASTs/codeGenAST.C
    A dyninstAPI/src/ASTs/codeGenAST.h
    A dyninstAPI/src/ASTs/functionCallAST.C
    A dyninstAPI/src/ASTs/functionCallAST.h
    A dyninstAPI/src/ASTs/genericStackAST.C
    A dyninstAPI/src/ASTs/genericStackAST.h
    A dyninstAPI/src/ASTs/jumpTargetAST.C
    A dyninstAPI/src/ASTs/jumpTargetAST.h
    A dyninstAPI/src/ASTs/memoryAccessAST.C
    A dyninstAPI/src/ASTs/memoryAccessAST.h
    A dyninstAPI/src/ASTs/nullAST.C
    A dyninstAPI/src/ASTs/nullAST.h
    A dyninstAPI/src/ASTs/operandAST.C
    A dyninstAPI/src/ASTs/operandAST.h
    A dyninstAPI/src/ASTs/operatorAST.C
    A dyninstAPI/src/ASTs/operatorAST.h
    A dyninstAPI/src/ASTs/originalAddressAST.C
    A dyninstAPI/src/ASTs/scrambleRegistersAST.C
    A dyninstAPI/src/ASTs/scrambleRegistersAST.h
    A dyninstAPI/src/ASTs/sequenceAST.C
    A dyninstAPI/src/ASTs/sequenceAST.h
    A dyninstAPI/src/ASTs/snippetAST.C
    A dyninstAPI/src/ASTs/snippetAST.h
    A dyninstAPI/src/ASTs/stackAST.C
    A dyninstAPI/src/ASTs/stackAST.h
    A dyninstAPI/src/ASTs/stackInsertionAST.C
    A dyninstAPI/src/ASTs/stackInsertionAST.h
    A dyninstAPI/src/ASTs/stackRemovalAST.C
    A dyninstAPI/src/ASTs/stackRemovalAST.h
    A dyninstAPI/src/ASTs/threadAST.C
    A dyninstAPI/src/ASTs/threadAST.h
    A dyninstAPI/src/ASTs/variableAST.C
    A dyninstAPI/src/ASTs/variableAST.h
    R dyninstAPI/src/AmdgpuEpilogue.C
    R dyninstAPI/src/AmdgpuEpilogue.h
    M dyninstAPI/src/AmdgpuPointHandler.C
    M dyninstAPI/src/AmdgpuPointHandler.h
    R dyninstAPI/src/AmdgpuPrologue.C
    R dyninstAPI/src/AmdgpuPrologue.h
    M dyninstAPI/src/BPatch_addressSpace.C
    M dyninstAPI/src/BPatch_binaryEdit.C
    M dyninstAPI/src/BPatch_function.C
    M dyninstAPI/src/BPatch_point.C
    M dyninstAPI/src/BPatch_snippet.C
    M dyninstAPI/src/IAPI_to_AST.C
    M dyninstAPI/src/IAPI_to_AST.h
    R dyninstAPI/src/OperandType.h
    M dyninstAPI/src/PointHandler.h
    M dyninstAPI/src/Relocation/DynInstrumenter.C
    M dyninstAPI/src/Relocation/DynInstrumenter.h
    M dyninstAPI/src/StackMod/StackModExpr.C
    M dyninstAPI/src/addressSpace.C
    M dyninstAPI/src/addressSpace.h
    R dyninstAPI/src/ast.C
    R dyninstAPI/src/ast.h
    M dyninstAPI/src/codegen.h
    M dyninstAPI/src/dynProcess.C
    M dyninstAPI/src/dynProcess.h
    M dyninstAPI/src/emit-aarch64.h
    M dyninstAPI/src/emit-amdgpu.C
    M dyninstAPI/src/emit-amdgpu.h
    M dyninstAPI/src/emit-power.h
    M dyninstAPI/src/emit-x86.C
    M dyninstAPI/src/emit-x86.h
    M dyninstAPI/src/emitter.h
    M dyninstAPI/src/inst-aarch64.C
    M dyninstAPI/src/inst-amdgpu.C
    M dyninstAPI/src/inst-power.C
    M dyninstAPI/src/inst-power.h
    M dyninstAPI/src/inst-winnt.C
    M dyninstAPI/src/inst-x86.C
    M dyninstAPI/src/inst.C
    M dyninstAPI/src/inst.h
    M dyninstAPI/src/instPoint.C
    M dyninstAPI/src/instPoint.h
    M dyninstAPI/src/linux-aarch64.C
    M dyninstAPI/src/linux-power.C
    M dyninstAPI/src/linux-x86.C
    M dyninstAPI/src/parse-aarch64.C
    M dyninstAPI/src/parse-power.C
    M dyninstAPI/src/parse-x86.C
    M dyninstAPI/src/pdwinnt.C
    M dyninstAPI/src/regTracker.C
    M dyninstAPI/src/regTracker.h
    M dyninstAPI/src/registerSpace/registerSpace.C
    M dyninstAPI/src/syscallNotification.C
    M dyninstAPI/src/trampolines/baseTramp.C
    M dyninstAPI/src/trampolines/baseTramp.h
    M tests/unit/dyninstAPI/emitter/amdgpu_gfx908.cpp
    M tests/unit/dyninstAPI/emitter/x86_64.cpp

  Log Message:
  -----------
  Merge branch 'master' into thaines/remove_parRegion


Compare: https://github.com/dyninst/dyninst/compare/aa974e11b267...5c3865ec2ef4

To unsubscribe from these emails, change your notification settings at 
https://github.com/dyninst/dyninst/settings/notifications
_______________________________________________
Dyninst-api mailing list
[email protected]
https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api

[DynInst_API:] [dyninst/dyninst] b907a1: Split up dyninstAPI AST node classes (#2125)

Reply via email to