Branch: refs/heads/thaines/cleanup_parse_cfg
  Home:   https://github.com/dyninst/dyninst
  Commit: 7bbb092d7d661a10189b874b167a9f3fa20d49ea
      
https://github.com/dyninst/dyninst/commit/7bbb092d7d661a10189b874b167a9f3fa20d49ea
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_block::img()

Its usage was removed by 62b7d1f21 in 2010.


  Commit: 4a41478e2e75cb485b703a38faf5c3b0fee40bfc
      
https://github.com/dyninst/dyninst/commit/4a41478e2e75cb485b703a38faf5c3b0fee40bfc
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C

  Log Message:
  -----------
  Clean up parse_func::getPtrToInstruction()

The code was commented out by 62b7d1f21 in 2010.


  Commit: e1e634df00134102bb3024d3ba8929b17a36e437
      
https://github.com/dyninst/dyninst/commit/e1e634df00134102bb3024d3ba8929b17a36e437
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/BPatch_basicBlock.C
    M dyninstAPI/src/function.C
    M dyninstAPI/src/parse-cfg.C

  Log Message:
  -----------
  Remove ROUGH_MEMORY_PROFILE

It's not used anymore.


  Commit: c865b351c0a39c3a3e29f28454e25fe853f79b0d
      
https://github.com/dyninst/dyninst/commit/c865b351c0a39c3a3e29f28454e25fe853f79b0d
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_block::compare

It's not used.


  Commit: d1eada6adc42510c90ebba035d65a143921a3699
      
https://github.com/dyninst/dyninst/commit/d1eada6adc42510c90ebba035d65a143921a3699
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_block::getCallee()

Its usage was removed by 4bc7f25d76db9 in 2020.


  Commit: c89ee2d6aec9cdb7b9ce41fb8e20a42b76f66eb0
      
https://github.com/dyninst/dyninst/commit/c89ee2d6aec9cdb7b9ce41fb8e20a42b76f66eb0
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/function.C
    M dyninstAPI/src/function.h

  Log Message:
  -----------
  Remove func_instance::getReachableBlocks()

Its usage was disabled by ab24c9bf0 in 2012 and removed by 780d7d1246
in 2021.


  Commit: d28778be7f47abbea468a4f0d2b3c361da655fc4
      
https://github.com/dyninst/dyninst/commit/d28778be7f47abbea468a4f0d2b3c361da655fc4
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_func::getReachableBlocks

It's no longer used.


  Commit: 6faf1b330b42b37569087d9555d9feb992e5afca
      
https://github.com/dyninst/dyninst/commit/6faf1b330b42b37569087d9555d9feb992e5afca
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove unneeded class forward decls in parse-cfg.h


  Commit: b4bac4c3e5a245c2cf6ee8e960c92303e6d914b4
      
https://github.com/dyninst/dyninst/commit/b4bac4c3e5a245c2cf6ee8e960c92303e6d914b4
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_block::getInsns

The offset is never used, so it's just equivalent to calling the version
in the base class. The comment is also out of date because the returned
value is never reused at its callsite.


  Commit: b377df55ce9aa97482b86f54d8dddb4034118527
      
https://github.com/dyninst/dyninst/commit/b377df55ce9aa97482b86f54d8dddb4034118527
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove unused ifuncPtr, ifuncCmp

These were added by c63e1528202 in 2005, but never used.


  Commit: a79ecf33f5f301e06a9bfccf09055624086d52df
      
https://github.com/dyninst/dyninst/commit/a79ecf33f5f301e06a9bfccf09055624086d52df
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/BPatch_object.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Removed unused includes in parse-cfg.h


  Commit: ef640e3e63ac4fc132562fa599c981f4622c3e67
      
https://github.com/dyninst/dyninst/commit/ef640e3e63ac4fc132562fa599c981f4622c3e67
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Cleanup includes in parse-cfg.h


  Commit: ee1c09fce0d2c4e3ef031f0954126240a584682c
      
https://github.com/dyninst/dyninst/commit/ee1c09fce0d2c4e3ef031f0954126240a584682c
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove using directives in parse-cfg.h


  Commit: e89b502edceec5360489b56f07ef0b100024f862
      
https://github.com/dyninst/dyninst/commit/e89b502edceec5360489b56f07ef0b100024f862
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_block::debugPrint

There's a clear copy/paste error in that it prints the sources as the
targets. I don't think anyone has ever used this.


  Commit: c121d28dd65f5921cea16f4b5762d010df2fbb24
      
https://github.com/dyninst/dyninst/commit/c121d28dd65f5921cea16f4b5762d010df2fbb24
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove unneeded friend delcaration in parse_block


  Commit: f12a623ea7c04114a28efad6d2ff338ce7598de9
      
https://github.com/dyninst/dyninst/commit/f12a623ea7c04114a28efad6d2ff338ce7598de9
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Make second parse_block ctor public, remove unneeded friend declaration

It's unclear why this was done instead of just making the constructor
public.


  Commit: 92489228dbefb360373cfad88a89d5b038cb881c
      
https://github.com/dyninst/dyninst/commit/92489228dbefb360373cfad88a89d5b038cb881c
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/addressSpace.C
    M dyninstAPI/src/block.C
    M dyninstAPI/src/inst-power.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Replace parse_block::firstInsnOffset with Block::start


  Commit: f6df62b298e0d8df25096f221622db95d39570d7
      
https://github.com/dyninst/dyninst/commit/f6df62b298e0d8df25096f221622db95d39570d7
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Replace parse_block::lastInsnOffset with Block::lastInsnAddr


  Commit: 7a08aa3df77d9775179df4309aa57bdafe3d454e
      
https://github.com/dyninst/dyninst/commit/7a08aa3df77d9775179df4309aa57bdafe3d454e
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Replace parse_block::endOffset() with Block::end()


  Commit: ed5219fedfe33ec8039773d4de11f84872bcea25
      
https://github.com/dyninst/dyninst/commit/ed5219fedfe33ec8039773d4de11f84872bcea25
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Replace parse_block::getSize() with Block::size()


  Commit: 602b5c683bba582a8901d028b24b76d52ec96bb8
      
https://github.com/dyninst/dyninst/commit/602b5c683bba582a8901d028b24b76d52ec96bb8
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove MSVC++ check in image_edge


  Commit: df7fd1886fa86b6d20c91190ede900fcbf350b4f
      
https://github.com/dyninst/dyninst/commit/df7fd1886fa86b6d20c91190ede900fcbf350b4f
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Clean up image_edge::src,trg


  Commit: fad63d446818ed77ca7b0206799d21fa63b1c347
      
https://github.com/dyninst/dyninst/commit/fad63d446818ed77ca7b0206799d21fa63b1c347
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove unneeded friend declaration in image_edge


  Commit: 92038d88b4044f801df5cdf7a82d5e3c68e92256
      
https://github.com/dyninst/dyninst/commit/92038d88b4044f801df5cdf7a82d5e3c68e92256
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h
    A dyninstAPI/src/parse_block.C
    A dyninstAPI/src/parse_block.h

  Log Message:
  -----------
  Extract parse_block


  Commit: 6aa191e5d59d6d584f505c218a93e7f50e459c95
      
https://github.com/dyninst/dyninst/commit/6aa191e5d59d6d584f505c218a93e7f50e459c95
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse_block.h

  Log Message:
  -----------
  Explicitly mark overrides in parse_block


  Commit: 567c0698176c04feb149a423d1498111669b4d47
      
https://github.com/dyninst/dyninst/commit/567c0698176c04feb149a423d1498111669b4d47
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse_block.C
    M dyninstAPI/src/parse_block.h

  Log Message:
  -----------
  Use in-class initializers in parse_block


  Commit: ce4ff6a1580dcaabb4d75a6235a5f9bcf3dcd0c8
      
https://github.com/dyninst/dyninst/commit/ce4ff6a1580dcaabb4d75a6235a5f9bcf3dcd0c8
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse_block.C

  Log Message:
  -----------
  Extract parse_block -- REBASE


  Commit: 3e8a4eb10a7b128c86d1c1131c0fba54f87836b2
      
https://github.com/dyninst/dyninst/commit/3e8a4eb10a7b128c86d1c1131c0fba54f87836b2
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse_block.C

  Log Message:
  -----------
  Simplify parse_block::isCallBlock()


  Commit: a354eddf96d3e415e8677cb90f364ebc7584d135
      
https://github.com/dyninst/dyninst/commit/a354eddf96d3e415e8677cb90f364ebc7584d135
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse_block.C

  Log Message:
  -----------
  Simplify parse_block::isIndirectTailCallBlock()


  Commit: 5f30627602f0cb7fe2194f61a0bd7bf40028b18c
      
https://github.com/dyninst/dyninst/commit/5f30627602f0cb7fe2194f61a0bd7bf40028b18c
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/Parsing.C
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove image_edge

It's no longer used.


  Commit: 3c196e77a71a58452eb4283ee3fd278840fb17f4
      
https://github.com/dyninst/dyninst/commit/3c196e77a71a58452eb4283ee3fd278840fb17f4
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/Parsing.C
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Fix PLT function handling in parse_func

Originally, isPLTFunction() just returned isPLTFunction_. That was
changed by 62b7d1f21 in 2010 to the current calculation. However, the
construction of a parse_func in DynCFGFactory::mkfunc didn't reflect
that change.

I don't think the check is parse_func::isPLTFunction() is strictly
necessary, but I've added it for assurances.


  Commit: f87172277c2c99e175c970cf93956936836c01e5
      
https://github.com/dyninst/dyninst/commit/f87172277c2c99e175c970cf93956936836c01e5
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C

  Log Message:
  -----------
  Simplify parse_func constructor


  Commit: 0e6829a0b3912c7c15ac78f8b56fcb182618577b
      
https://github.com/dyninst/dyninst/commit/0e6829a0b3912c7c15ac78f8b56fcb182618577b
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Use default dtor in parse_func


  Commit: 9425facfebce579c003e7415f3f053e05712c24c
      
https://github.com/dyninst/dyninst/commit/9425facfebce579c003e7415f3f053e05712c24c
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove compile guard on parse_func::savesReturnAddr()


  Commit: 91b5e658d4bbb5c3fa96d1a1c934f106c2ed9bf9
      
https://github.com/dyninst/dyninst/commit/91b5e658d4bbb5c3fa96d1a1c934f106c2ed9bf9
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_func::compare

It's not used.


  Commit: 13191ad0f501524b7a1d49f48ff61ebc0f383eab
      
https://github.com/dyninst/dyninst/commit/13191ad0f501524b7a1d49f48ff61ebc0f383eab
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_func::copyNames

It was added by 0f583e73a in 2005, but never implemented.


  Commit: c284b511c604c03ac6e1f1796f642513a0887444
      
https://github.com/dyninst/dyninst/commit/c284b511c604c03ac6e1f1796f642513a0887444
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Remove parse_func::parse()

It was added by ecd7eac74 in 2009, but never implemented.


  Commit: 048e9407369aa11d9bb21206a20944c53bf3a74a
      
https://github.com/dyninst/dyninst/commit/048e9407369aa11d9bb21206a20944c53bf3a74a
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/dynThread.C
    M dyninstAPI/src/function.C
    M dyninstAPI/src/image.C
    M dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Replace parse_func::getOffset() with Function::addr()


  Commit: 3f904f349312ef2e108fa3370e44a94691c943ee
      
https://github.com/dyninst/dyninst/commit/3f904f349312ef2e108fa3370e44a94691c943ee
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Inline parse_func::getPtrOffset()


  Commit: 0d75c90789e50edbeb6c21993cd78d11ce9ac6a1
      
https://github.com/dyninst/dyninst/commit/0d75c90789e50edbeb6c21993cd78d11ce9ac6a1
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse-cfg.h

  Log Message:
  -----------
  Inline parse_func::getSymTabSize()


  Commit: 14693a19fd7bb7c09dc1283906e097f3af8e10ff
      
https://github.com/dyninst/dyninst/commit/14693a19fd7bb7c09dc1283906e097f3af8e10ff
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    R dyninstAPI/src/parse-cfg.C
    M dyninstAPI/src/parse-cfg.h
    M dyninstAPI/src/parse_block.C
    A dyninstAPI/src/parse_func.C
    A dyninstAPI/src/parse_func.h

  Log Message:
  -----------
  Extract parse_func


  Commit: 359a75c11a7b6bd1fed958a585dd7b39e00aff65
      
https://github.com/dyninst/dyninst/commit/359a75c11a7b6bd1fed958a585dd7b39e00aff65
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/src/parse_func.h

  Log Message:
  -----------
  Remove redundant access specifier in parse_func


  Commit: 5de7dfa46b59a5cc1b531a3301144f77979f30e4
      
https://github.com/dyninst/dyninst/commit/5de7dfa46b59a5cc1b531a3301144f77979f30e4
  Author: Tim Haines <[email protected]>
  Date:   2026-03-03 (Tue, 03 Mar 2026)

  Changed paths:
    M dyninstAPI/CMakeLists.txt
    M dyninstAPI/src/Parsing-arch.C
    M dyninstAPI/src/Parsing.C
    M dyninstAPI/src/Relocation/DynCFGMaker.C
    M dyninstAPI/src/Relocation/DynInstrumenter.C
    M dyninstAPI/src/block.C
    M dyninstAPI/src/block.h
    M dyninstAPI/src/function.h
    M dyninstAPI/src/inst-power.C
    M dyninstAPI/src/inst-x86.h
    M dyninstAPI/src/inst.C
    M dyninstAPI/src/instPoint.C
    R dyninstAPI/src/parse-cfg.h
    M dyninstAPI/src/unix.C

  Log Message:
  -----------
  Remove parse-cfg.h


Compare: 
https://github.com/dyninst/dyninst/compare/7bbb092d7d66%5E...5de7dfa46b59

To unsubscribe from these emails, change your notification settings at 
https://github.com/dyninst/dyninst/settings/notifications
_______________________________________________
Dyninst-api mailing list
[email protected]
https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api

Reply via email to