Branch: refs/heads/master
Home: https://github.com/dyninst/dyninst
Commit: 180cf802dd18358a710134b96fab4122d63c14ab
https://github.com/dyninst/dyninst/commit/180cf802dd18358a710134b96fab4122d63c14ab
Author: Tim Haines <[email protected]>
Date: 2026-03-05 (Thu, 05 Mar 2026)
Changed paths:
M dyninstAPI/CMakeLists.txt
M dyninstAPI/src/BPatch_basicBlock.C
M dyninstAPI/src/BPatch_object.C
M dyninstAPI/src/Parsing-arch.C
M dyninstAPI/src/Parsing.C
M dyninstAPI/src/Relocation/DynCFGMaker.C
M dyninstAPI/src/Relocation/DynInstrumenter.C
M dyninstAPI/src/addressSpace.C
M dyninstAPI/src/block.C
M dyninstAPI/src/block.h
M dyninstAPI/src/dynThread.C
M dyninstAPI/src/function.C
M dyninstAPI/src/function.h
M dyninstAPI/src/image.C
M dyninstAPI/src/inst-power.C
M dyninstAPI/src/inst-x86.h
M dyninstAPI/src/inst.C
M dyninstAPI/src/instPoint.C
R dyninstAPI/src/parse-cfg.C
R dyninstAPI/src/parse-cfg.h
A dyninstAPI/src/parse_block.C
A dyninstAPI/src/parse_block.h
A dyninstAPI/src/parse_func.C
A dyninstAPI/src/parse_func.h
M dyninstAPI/src/unix.C
Log Message:
-----------
Clean up, refactor dyninstAPI parse_func and parse_block classes (#2162)
* Remove parse_block::img()
Its usage was removed by 62b7d1f21 in 2010.
* Clean up parse_func::getPtrToInstruction()
The code was commented out by 62b7d1f21 in 2010.
* Remove ROUGH_MEMORY_PROFILE
It's not used anymore.
* Remove parse_block::compare
It's not used.
* Remove parse_block::getCallee()
Its usage was removed by 4bc7f25d76db9 in 2020.
* Remove func_instance::getReachableBlocks()
Its usage was disabled by ab24c9bf0 in 2012 and removed by 780d7d1246
in 2021.
* Remove parse_func::getReachableBlocks
It's no longer used.
* Remove unneeded class forward decls in parse-cfg.h
* Remove parse_block::getInsns
The offset is never used, so it's just equivalent to calling the version
in the base class. The comment is also out of date because the returned
value is never reused at its callsite.
* Remove unused ifuncPtr, ifuncCmp
These were added by c63e1528202 in 2005, but never used.
* Removed unused includes in parse-cfg.h
* Cleanup includes in parse-cfg.h
* Remove using directives in parse-cfg.h
* Remove parse_block::debugPrint
There's a clear copy/paste error in that it prints the sources as the
targets. I don't think anyone has ever used this.
* Remove unneeded friend delcaration in parse_block
* Make second parse_block ctor public, remove unneeded friend declaration
It's unclear why this was done instead of just making the constructor
public.
* Replace parse_block::firstInsnOffset with Block::start
* Replace parse_block::lastInsnOffset with Block::lastInsnAddr
* Replace parse_block::endOffset() with Block::end()
* Replace parse_block::getSize() with Block::size()
* Remove MSVC++ check in image_edge
* Clean up image_edge::src,trg
* Remove unneeded friend declaration in image_edge
* Extract parse_block
* Explicitly mark overrides in parse_block
* Use in-class initializers in parse_block
* Extract parse_block -- REBASE
* Simplify parse_block::isCallBlock()
* Simplify parse_block::isIndirectTailCallBlock()
* Remove image_edge
It's no longer used.
* Fix PLT function handling in parse_func
Originally, isPLTFunction() just returned isPLTFunction_. That was
changed by 62b7d1f21 in 2010 to the current calculation. However, the
construction of a parse_func in DynCFGFactory::mkfunc didn't reflect
that change.
I don't think the check is parse_func::isPLTFunction() is strictly
necessary, but I've added it for assurances.
* Simplify parse_func constructor
* Use default dtor in parse_func
* Remove compile guard on parse_func::savesReturnAddr()
* Remove parse_func::compare
It's not used.
* Remove parse_func::copyNames
It was added by 0f583e73a in 2005, but never implemented.
* Remove parse_func::parse()
It was added by ecd7eac74 in 2009, but never implemented.
* Replace parse_func::getOffset() with Function::addr()
* Inline parse_func::getPtrOffset()
* Inline parse_func::getSymTabSize()
* Extract parse_func
* Remove redundant access specifier in parse_func
* Remove parse-cfg.h
* Mark parse_block::id() as 'override'
To unsubscribe from these emails, change your notification settings at
https://github.com/dyninst/dyninst/settings/notifications
_______________________________________________
Dyninst-api mailing list
[email protected]
https://lists.cs.wisc.edu/mailman/listinfo/dyninst-api
