> From: Konstantin Khlebnikov [mailto:khlebni...@yandex-team.ru] > Sent: Wednesday, April 17, 2019 1:13 AM > To: net...@vger.kernel.org; intel-wired-...@lists.osuosl.org; linux- > ker...@vger.kernel.org; Kirsher, Jeffrey T <jeffrey.t.kirs...@intel.com> > Cc: Sasha Levin <sas...@kernel.org>; Joseph Yasi <joe.y...@gmail.com>; > Brown, Aaron F <aaron.f.br...@intel.com>; Alexander Duyck > <alexander.du...@gmail.com>; e1000-devel@lists.sourceforge.net > Subject: [PATCH 2/2] e1000e: start network tx queue only when link is up > > Driver does not want to keep packets in tx queue when link is lost. > But present code only reset NIC to flush them, but does not prevent > queuing new packets. Moreover reset sequence itself could generate > new packets via netconsole and NIC falls into endless reset loop. > > This patch wakes tx queue only when NIC is ready to send packets. > > This is proper fix for problem addressed by commit 0f9e980bf5ee > ("e1000e: fix cyclic resets at link up with active tx"). > > Signed-off-by: Konstantin Khlebnikov <khlebni...@yandex-team.ru> > Suggested-by: Alexander Duyck <alexander.du...@gmail.com> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Tested-by: Aaron Brown <aaron.f.br...@intel.com> Again, more of a regression check than a test that the patch solves the problem as I did not manage to trigger the hang.
_______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
