> From: Konstantin Khlebnikov [mailto:[email protected]] > Sent: Wednesday, April 17, 2019 1:13 AM > To: [email protected]; [email protected]; linux- > [email protected]; Kirsher, Jeffrey T <[email protected]> > Cc: Sasha Levin <[email protected]>; Joseph Yasi <[email protected]>; > Brown, Aaron F <[email protected]>; Alexander Duyck > <[email protected]>; [email protected] > Subject: [PATCH 2/2] e1000e: start network tx queue only when link is up > > Driver does not want to keep packets in tx queue when link is lost. > But present code only reset NIC to flush them, but does not prevent > queuing new packets. Moreover reset sequence itself could generate > new packets via netconsole and NIC falls into endless reset loop. > > This patch wakes tx queue only when NIC is ready to send packets. > > This is proper fix for problem addressed by commit 0f9e980bf5ee > ("e1000e: fix cyclic resets at link up with active tx"). > > Signed-off-by: Konstantin Khlebnikov <[email protected]> > Suggested-by: Alexander Duyck <[email protected]> > --- > drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > Tested-by: Aaron Brown <[email protected]> Again, more of a regression check than a test that the patch solves the problem as I did not manage to trigger the hang.
_______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
