David Acker wrote: > David Daney wrote: >> diff --git a/drivers/net/e100.c b/drivers/net/e100.c >> index 19d32a2..fb8d551 100644 >> --- a/drivers/net/e100.c >> +++ b/drivers/net/e100.c >> @@ -1840,6 +1840,11 @@ static int e100_rx_indicate(struct nic *nic, >> struct rx *rx, >> >> if (readb(&nic->csr->scb.status) & rus_no_res) >> nic->ru_running = RU_SUSPENDED; >> + /* We are done looking at the buffer. Prepare it for >> + * more DMA. */ >> + pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr, >> + sizeof(struct rfd), >> + PCI_DMA_FROMDEVICE); >> return -ENODATA; >> } >> > Should the call to pci_dma_sync_single_for_device be DMA_TO_DEVICE since > we are giving the memory back to the device?
No. We are giving the memory back to the device, but the direction of the data transfer is from the device to memory. David Daney ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel
