Brandeburg, Jesse wrote: > On Fri, 31 Oct 2008, Russell King - ARM Linux wrote: > >> On Thu, Oct 30, 2008 at 05:27:59PM +0100, Anders Grafström wrote: >>> The e100 driver triggers BUG_ON(buf->direction != dir) >>> by doing pci_map_single(..., PCI_DMA_BIDIRECTIONAL) >>> and pci_dma_sync_single_for_device(..., PCI_DMA_TODEVICE). >>> >>> I'm guessing it's allowed to do that and that something like >>> the patch below is called for? >> No, it is not allowed to do that - that's why it's called "BUG_ON". >> Changing the DMA direction, especially with dmabounce will result >> in unexpected behaviour. > > okay, how about this patch... only compile tested as I couldn't get > net-next-2.6 to boot on my test machine. I'll get some testing done on > this, but in the meantime.... > > e100: fix dma error in direction for mapping > > From: Jesse Brandeburg <[EMAIL PROTECTED]>
I failed to save this patch (flowed format?) but I applied it manually to 2.6.28-rc4 and tried it. Appears to work. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel
