From: "Brandeburg, Jesse" <[email protected]> Date: Wed, 18 Mar 2009 10:24:18 -0700 (Pacific Daylight Time)
> Interesting, this code has been there for eons (and probably this > behavior) but that doesn't mean its not a problem. > > We are in the process of figuring out if there are any hardware corner > cases to changing this code (particularly in e1000) > > Initial thoughts are: > 1) kcalloc an array that we then populate with the hash functions, and > then program every location only once (never flush) > 2) only program a single hash value each time a multicast is added (bad > because we can't tell the difference in the list since the last time > the OS gave us the list) > > It really seems like this should be fixable, and I agree that the driver > behavior is far from optimal, however well entrenched. Just do what tg3 does to fix this now, get fancy and "beautiful" later. ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
