Rafael J. Wysocki wrote:
> On Tuesday 15 September 2009, Karol Lewandowski wrote:
>> Hello,
>>
>> I'm getting following oops sometimes during resume on my Thinkpad T21
>> (where "sometimes" means about 10/1 good/bad ratio):
>>
>> ifconfig: page allocation failure. order:5, mode:0x8020
> 
> Well, this only tells you that an attempt to make order 5 allocation failed,
> which is not unusual at all.
> 
> Allocations of this order are quite likely to fail if memory is fragmented,
> the probability of which rises with the number of suspend-resume cycles 
> already
> carried out.
> 
> I guess the driver releases its DMA buffer during suspend and attempts to
> allocate it back on resume, which is not really smart (if that really is the
> case).
> 
Yes, we free a 70KB block (0x80 by 0x230 bytes) on suspend and 
reallocate on resume, and so that's an Order 5 request. It looks 
symmetric, and hasn't changed for years. I don't think we are leaking 
memory, which points back to that the memory is too fragmented to 
satisfy the request.

I also concur that Rafael's commit 6905b1f1 shouldn't change the logic 
in the driver for systems with e100 (like yours Karol) that could 
already sleep, and I don't see anything else in the driver that looks to 
be relevant. I'm expecting that your test result without commit 6905b1f1 
will still show the problem.

So I wonder if this new issue may be triggered by some other change in 
the memory subsystem ?

Karol, how much physical RAM do you have in this system ? I'd expect 
that the fragmentation would be less of an issue if there's simply more 
memory in total.

Unfortunately I still have no actual repro in house.

I can try to rework the codepaths around suspend & resume so that we 
don't free & reallocate this order 5 memory, but I think its risky. I'm 
looking into that now.

Thanks


> Thanks,
> Rafael


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay 
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel

Reply via email to