Stephen Hemminger wrote: > On Sat, 31 Oct 2009 18:39:52 +0900 > Naohiro Ooiwa <[email protected]> wrote: > >> Hi All >> >> I resend my patch. >> Sorry, my previous mail lacked an explanation. >> >> >> The e1000 driver doesn't let the power down when running ifdown command. >> So, I set to the D3hot state of a PCI device at the end of e1000_close(). >> >> With this modification, e1000 driver reduces power by ifdown. >> It's about 6 watts when I measured a total power of one server machine >> in my environment. >> >> I tested this patch. The result is good enough to me. >> >> Could you please check my patch ? >> If I should have other considerations, please tell me. >>
Hi Stephen Thank you so much for your reply. > Does this work with Wake On Lan? Yes, it works WOL. But I worry that my test is enough. They are following: - simple data transmission after ifdown;ifup. - enable wol, ifup network device, system shutdown, and make sure wol work. - enable wol, ifdown network device, system shutdown, and make sure wol work. - while [ 0 ] ; do ifdown eth0 ; ifup eth0 ; done - while [ 0 ] ; do modprobe e1000 ; rmmod e1000 ; done > @@ -1265,6 +1287,7 @@ static int e1000_open(struct net_device *netdev) > goto err_setup_rx; > > e1000_power_up_phy(adapter); > + e1000_reset(adapter); > > adapter->mng_vlan_id = E1000_MNG_VLAN_NONE; > if ((hw->mng_cookie.status & This code fix problem that e1000 driver doesn't work to auto-negotiation once in a while. Maybe, the cause is that set state to D0 just before it. I found it by repeat of ifup and ifdown. If you find out other points and any necessary tests from my patch, please tell me. I will make sure them. Thanks you. Naohiro Ooiwa ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel
