On Wed, 2010-10-13 at 21:57 -0700, Jeff Kirsher wrote: > On Wed, 2010-10-13 at 15:28 -0700, Joe Perches wrote: > Sorry I am not ignoring you, I was taking a closer look at your patch. > > What regression testing would actually be done? > The Makefile and Kconfig needs more work. I applied your patch and none > of the Intel Wired drivers build.
Care to describe the Makefile/Kconfig issues you have seen? I built it allyesconfig, defconfig, allmodconfig and allnoconfig. Perhaps you need to use "git am foo" in a test branch instead of "patch -p1 < foo" ? > I am working on providing an updated RFC patch to resolve the > Makefile/Kconfig issues I found and few other minor issues I have > found. Oh good. cheers, Joe ------------------------------------------------------------------------------ Beautiful is writing same markup. Internet Explorer 9 supports standards for HTML5, CSS3, SVG 1.1, ECMAScript5, and DOM L2 & L3. Spend less time writing and rewriting code and more time creating great experiences on the web. Be a part of the beta today. http://p.sf.net/sfu/beautyoftheweb _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired