Le mardi 14 décembre 2010 à 18:32 -0200, Flavio Leitner a écrit : > Provides accurate stats at the time user reads them. > > Signed-off-by: Flavio Leitner <[email protected]> > --- > drivers/net/e1000e/e1000.h | 5 ++- > drivers/net/e1000e/ethtool.c | 27 +++++++++------- > drivers/net/e1000e/netdev.c | 68 ++++++++++++++++++++++++----------------- > 3 files changed, 59 insertions(+), 41 deletions(-) > > diff --git a/drivers/net/e1000e/e1000.h b/drivers/net/e1000e/e1000.h > index fdc67fe..5a5e944 100644 > --- a/drivers/net/e1000e/e1000.h > +++ b/drivers/net/e1000e/e1000.h > @@ -363,6 +363,8 @@ struct e1000_adapter { > /* structs defined in e1000_hw.h */ > struct e1000_hw hw; > > + spinlock_t stats64_lock; > + struct rtnl_link_stats64 stats64;
I am not sure why you add this stats64 in e1000_adapter ? Why isnt it provided by callers (automatic variable, or provided to ndo_get_stats64()). I dont see accumulators, only a full rewrite of this structure in e1000e_update_stats() ? ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
