On Wed, 15 Dec 2010 19:16:55 +0100 Michał Mirosław <[email protected]> wrote:
> On Tue, Dec 14, 2010 at 07:07:27PM -0800, Stephen Hemminger wrote: > > On Wed, 15 Dec 2010 02:24:08 +0100 (CET) > > Michał Mirosław <[email protected]> wrote: > > > Some drivers are using skb_transport_offset(skb) instead of > > > skb->csum_start > > > for NETIF_F_HW_CSUM offload. This does not matter now, but if someone > > > implements checksumming of encapsulated packets then this will break > > > silently. > > > > > > TSO output paths are left as they are, since they are for IP+TCP only > > > (might be worth converting though). > > > > > > Signed-off-by: Michał Mirosław <[email protected]> > > Which if any of these drivers did you test on real hardware? > > I'm running it on skge, with additional patch that changes it to use > NETIF_F_HW_CSUM instead of NETIF_F_IP_CSUM. BTW, why it is not advertising > full HW checksum in vanilla kernel? Are there any known hardware bugs in > there? > > Best Regards, > Michał Mirosław The driver was written from vendor sk98lin driver and that driver only did IP checksum, therefore I did not trust the hardware. The chipset is old, and not used in new designs, no documentation is up to date (and I didn't have any). Please don't enable non-IPv4 checksum offload on this hardware, there is too big a risk of it not working on all hardware. -- ------------------------------------------------------------------------------ Lotusphere 2011 Register now for Lotusphere 2011 and learn how to connect the dots, take your collaborative environment to the next level, and enter the era of Social Business. http://p.sf.net/sfu/lotusphere-d2d _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
