>-----Original Message----- >From: Jean-Mickael Guerin [mailto:[email protected]] >Sent: Thursday, April 07, 2011 12:17 AM >To: [email protected] >Subject: [E1000-devel] CRC stripping on 82598 and 82599 > >Hello, > >It seems CRC is not stripped out on 82599, neither on 82598. >The ixgbe driver is setting RDRXCTL for 82599, nothing else. >>From datasheet I found that RDRXCTL.CRCStrip and HLREG0.RXCRCSTRP >must be set to the same value. > >I tested this patch (ixgbe-3.2.10) on 82598: always set >IXGBE_HLREG0_RXCRCSTRP, >and it CRC is stripped now: > >--- a/src/ixgbe_main.c >+++ b/src/ixgbe_main.c >@@ -3439,6 +3439,8 @@ static void ixgbe_set_rx_buffer_len(struct >ixgbe_adapter *adapter) > hlreg0 = IXGBE_READ_REG(hw, IXGBE_HLREG0); > /* set jumbo enable since MHADD.MFS is keeping size locked at >max_frame */ > hlreg0 |= IXGBE_HLREG0_JUMBOEN; >+ /* Enable CRC stripping */ >+ hlreg0 |= IXGBE_HLREG0_RXCRCSTRP; > IXGBE_WRITE_REG(hw, IXGBE_HLREG0, hlreg0); > > >I'm going to test on 82599 too. >I can't test for other NIC than 82598 and 82599, may a test for (82598 || >82599) should >be added.
Thanks for the patch. Are you seeing an issue where the CRC is not being stripped, or is the patch just to satisfy the requirement in the datasheet? If you are seeing a problem could you provide the values of the HLREG0 and RDRXCTL? You can use the ethregs tool available for download from e1000.sf.net. A detailed information about your HW would also be helpful such as lspci -vvv and ethtool -e. Thanks, Emil > >Regards, >Jean-Mickael > >--------------------------------------------------------------------------- >--- >Xperia(TM) PLAY >It's a major breakthrough. An authentic gaming >smartphone on the nation's most reliable network. >And it wants your games. >http://p.sf.net/sfu/verizon-sfdev >_______________________________________________ >E1000-devel mailing list >[email protected] >https://lists.sourceforge.net/lists/listinfo/e1000-devel >To learn more about Intel® Ethernet, visit >http://communities.intel.com/community/wired ------------------------------------------------------------------------------ Forrester Wave Report - Recovery time is now measured in hours and minutes not days. Key insights are discussed in the 2010 Forrester Wave Report as part of an in-depth evaluation of disaster recovery service providers. Forrester found the best-in-class provider in terms of services and vision. Read this report now! http://p.sf.net/sfu/ibm-webcastpromo _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
