On Sun, 08 May 2011 11:54:32 -0700 Yinghai Lu <[email protected]> wrote:
> > Need to use it in _e1000e_disable_aspm. > when aer happens, > pci_walk_bus already have down_read(&pci_bus_sem)... > then report_slot_reset > ==> e1000_io_slot_reset > ==> e1000e_disable_aspm > ==> pci_disable_link_state... > > We can not use pci_disable_link_state, and it will try to hold pci_bus_sem > again. > > Try to have __pci_disable_link_state that will not need to hold pci_bus_sem. What about the other callers of e1000e_disable_aspm? Do they already have the lock held or is it just reset that needs the already locked version? > +extern void __pci_disable_link_state(struct pci_dev *pdev, int state); > extern void pcie_clear_aspm(void); > extern void pcie_no_aspm(void); > #else pci_disable_link_state_locked would be more descriptive and would match other usage in the kernel. Thanks, -- Jesse Barnes, Intel Open Source Technology Center ------------------------------------------------------------------------------ WhatsUp Gold - Download Free Network Management Software The most intuitive, comprehensive, and cost-effective network management toolset available today. Delivers lowest initial acquisition cost and overall TCO of any competing solution. http://p.sf.net/sfu/whatsupgold-sd _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
