On Mon, Jun 6, 2011 at 04:52, Esa-Pekka Pyokkimies <esa-pekka.pyokkim...@stonesoft.com> wrote: > Hello! > > I noticed that ixgbe driver doesn't report SUPPORTED_Pause and > ADVERTISED_Pause flags to ethtool. This means that ethtool > always reports: > Supported pause frame use: No > Advertised pause frame use: No > I added reporting for capabilities and advertising. > I tested it with our ixgbe card and latest ethtool > from git repo. I also need to add capability to > change advertising parameters with "ethtool -s advertise %x", > but will send in a different patch if this patch looks ok. > > Signed-off-by: Esa-Pekka Pyokkimies <esa-pekka.pyokkim...@stonesoft.com> > ---
Thank you for the patch, I have added the patch into my queue. Upon initial review of the patch, there appear that some changes will need to be made. Sorry if I am vague, Don is looking into it to ensure your logic was correct or if additional changes will need to be made. If you want to revise your patch based on what Don finds, that would be greatly appreciated. -- Cheers, Jeff ------------------------------------------------------------------------------ EditLive Enterprise is the world's most technically advanced content authoring tool. Experience the power of Track Changes, Inline Image Editing and ensure content is compliant with Accessibility Checking. http://p.sf.net/sfu/ephox-dev2dev _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired