On Fri, 2011-12-02 at 01:11 -0600, Kumar Gala wrote: > From: Prabhakar <[email protected]> > > If the kernel config does not have MSI enabled (CONFIG_PCI_MSI) the driver > should not default to MSI interrupt mode but legacy interrupt mode.
It is supposed to automatically fall-back to legacy interrupt mode. Does that not work? Also, are there really systems with PCI Express and no MSI support? Ben. > Signed-off-by: Jin Qing <[email protected]> > Signed-off-by: Prabhakar <[email protected]> > Signed-off-by: Kumar Gala <[email protected]> > --- > drivers/net/ethernet/intel/e1000e/param.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/ethernet/intel/e1000e/param.c > b/drivers/net/ethernet/intel/e1000e/param.c > index 20e93b0..18c35c6 100644 > --- a/drivers/net/ethernet/intel/e1000e/param.c > +++ b/drivers/net/ethernet/intel/e1000e/param.c > @@ -388,8 +388,13 @@ void __devinit e1000e_check_options(struct e1000_adapter > *adapter) > static struct e1000_option opt = { > .type = range_option, > .name = "Interrupt Mode", > +#ifdef CONFIG_PCI_MSI > .err = "defaulting to 2 (MSI-X)", > .def = E1000E_INT_MODE_MSIX, > +#else > + .err = "defaulting to 0 (Legacy)", > + .def = E1000E_INT_MODE_LEGACY, > +#endif > .arg = { .r = { .min = MIN_INTMODE, > .max = MAX_INTMODE } } > }; -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. ------------------------------------------------------------------------------ All the data continuously generated in your IT infrastructure contains a definitive record of customers, application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-novd2d _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
