On Wed, Dec 07, 2011 at 02:36:20PM +0800, Michael Wang wrote:
> On 12/07/2011 02:19 PM, Joe Perches wrote:
[snip]
> > if (*i2cctl & IXGBE_I2C_DATA_IN)
> > - data = 1;
> > + data = true;
> > else
> > - data = 0;
> > + data = false;
> >
> > return data;
Yuck...
bool f(whatever)
{
bool data;
if (expression)
data = true;
else
data = false;
return data;
}
is amazingly unidiomatic. Hell, if nothing else it's
bool data = expression;
return data;
if not an outright
return expression;
or
return (bool)expression;
if you want to underline that it's treated as boolean... What tool
has produced that patch?
------------------------------------------------------------------------------
Cloud Services Checklist: Pricing and Packaging Optimization
This white paper is intended to serve as a reference, checklist and point of
discussion for anyone considering optimizing the pricing and packaging model
of a cloud services business. Read Now!
http://www.accelacomm.com/jaw/sfnl/114/51491232/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
