I am interested in to see if you have actual test case and more importantly test data that shows that kernel and device indexes are not synchronized any more.
-Tushar >-----Original Message----- >From: [email protected] [mailto:[email protected]] >On Behalf Of Samuel Thibault >Sent: Thursday, May 17, 2012 4:02 PM >To: Kirsher, Jeffrey T; Brandeburg, Jesse; Allan, Bruce W; Wyborny, >Carolyn; Skidmore, Donald C; Rose, Gregory V; Waskiewicz Jr, Peter P; >Duyck, Alexander H; Ronciak, John; David S. Miller; Jiri Pirko; Dean >Nelson; [email protected]; [email protected] >Cc: [email protected] >Subject: [PATCH] e1000: Reset rx ring index on receive overrun > >At high traffic rate, the rx ring may get completely filled before we >manage to consume it. After it is filled, the kernel and device indexes >are not synchronized any more, so we have to reset them, otherwise the >kernel will be stuck waiting for the wrong slot to be filled. > >Signed-off-by: Samuel Thibault <[email protected]> > >--- >This is just a patch suggestion, I'm not an expert in network drivers, I >leave to actual driver authors to bake a better version. > >diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c >b/drivers/net/ethernet/intel/e1000/e1000_main.c >index 37caa88..77c8dbc 100644 >--- a/drivers/net/ethernet/intel/e1000/e1000_main.c >+++ b/drivers/net/ethernet/intel/e1000/e1000_main.c >@@ -3759,6 +3759,21 @@ static irqreturn_t e1000_intr(int irq, void *data) > if (unlikely(test_bit(__E1000_DOWN, &adapter->flags))) > return IRQ_HANDLED; > >+ if (unlikely(icr & E1000_ICR_RXO)) { >+ /* Receive Overrun */ >+ u32 rctl; >+ int i; >+ rctl = er32(RCTL); >+ ew32(RCTL, rctl & ~E1000_RCTL_EN); >+ for (i = 0; i < adapter->num_rx_queues; i++) { >+ memset(adapter->rx_ring[i].desc, 0, adapter- >>rx_ring[i].size); >+ adapter->rx_ring[i].next_to_clean = 0; >+ } >+ ew32(RDH, 0); >+ ew32(RCTL, rctl); >+ adapter->netdev->stats.rx_fifo_errors++; >+ } >+ > if (unlikely(icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC))) { > hw->get_link_status = 1; > /* guard against interrupt when we're going down */ >-- >To unsubscribe from this list: send the line "unsubscribe netdev" in the >body of a message to [email protected] More majordomo info at >http://vger.kernel.org/majordomo-info.html ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
