[with inline attachments]

Hi list,

I see a NULL pointer deref at e1000(e)_probe() time when using version
1.11.3 of the driver, see attached output.

After checking the driver source I see that the ->check_reset_block()
PHY op is NULL, which is because it is left uninitialized in
e1000_init_phy_params_82571() when not using a PHY:

    if (hw->phy.media_type != e1000_media_type_copper) {
        phy->type = e1000_phy_none;
        return 0;
    }

Checking ->check_reset_block() for NULL-ness fixes the issue for me,
see attached patch.  Is it ok for you?

The bug seems also to be present in v2.0.0 of the driver, but this is
untested.

Thanks in advance!

 /holger

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit 
http://communities.intel.com/community/wired

Reply via email to