On 07/25/2012 02:44 PM, Greg Rose wrote: > Chris Friesen<[email protected]> wrote: > >> Just noticed something suspicious in ixgbe_ndo_set_vf_mac(). >> >> We set adapter->vfinfo[vf].pf_set_mac twice, once unconditionally and >> then once conditionally. Should that first one be deleted? > The first MAC address you set is overwritten and replaced with the new > one. > > Using the ip tool to set the VF MAC will only set its primary MAC > address.
Okay, but the pf_set_mac flag is just a bool. Why are we setting it twice? Presumably if the call to ixgbe_set_vf_mac() fails then we don't want to set that flag and so the first call should be removed. If we do want to set it unconditionally, why are setting it a second time after the call to ixgbe_set_vf_mac()? Chris ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
