On 10/14/2012 10:19 AM, Dmitry Fleytman wrote: > There is a race condition in e1000 driver. > It enables HW receive before RX rings initalization. > In case of specific timing this may lead to host memory corruption > due to DMA write to arbitrary memory location. > Following patch fixes this issue by reordering initialization steps. > > Other Intel network drivers does not seem to have this issue. > > Dmitry Fleytman (1): > RX initialization sequence fixed - enable RX after corresponding ring > initialization only > > drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 9 +++++---- > drivers/net/ethernet/intel/e1000/e1000_main.c | 18 ++++++++++++++++-- > 2 files changed, 21 insertions(+), 6 deletions(-) >
What device was it you saw this issue with? The reason why I ask is because I suspect this change should cause most of our e1000 hardware to lock up since normally if you allocate buffers and then enable Rx it will mean the ring was not updated and it will treat it as if there are no buffers available. Thanks, Alex ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
