OK, got it reproduced and fixed. Turns out that your fix with the masking and byte swapping was spot on.
If you want to respin your patch to remove the unconditional setting of the IGBVF_FLAG_RX_LB_VLAN_BSWAP flag, you should be good to go. Send that patch to this list and Jeff will add it to his queue and get it pushed upstream so you get credit for the fix. Nice work. -Mitch > -----Original Message----- > From: Chris Friesen [mailto:chris.frie...@genband.com] > Sent: Wednesday, November 14, 2012 12:45 PM > To: Williams, Mitch A > Cc: Wyborny, Carolyn; e1000-devel@lists.sourceforge.net; Ronciak, John; > Allan, Bruce W; Brandeburg, Jesse > Subject: Re: [E1000-devel] BUG? strange behavior with vlans and virtual > functions on i350 -- possible solution > > On 11/14/2012 02:23 PM, Williams, Mitch A wrote: > > NAK, at least the second half. The IGBVF_FLAG_RX_LB_VLAN_BSWAP tag is > > specifically to work around an errata on the i350. This change would > > break the 82576. > > I see that you're explicitly checking for loopback packets and only > converting from big-endian for them. > > This seems strange, given that the datasheets for both the i350 and the > 82576 state that the VLAN tag is big-endian. If it's actually little- > endian then the datasheets need updating. > > > Chris, I'm working on this right now and should have a setup ready for > > repro by the end of the day. Carolyn and I will work together to get > > this reproduced and fixed for you. > > Okay, fair enough. > > Chris ------------------------------------------------------------------------------ Monitor your physical, virtual and cloud infrastructure from a single web console. Get in-depth insight into apps, servers, databases, vmware, SAP, cloud infrastructure, etc. Download 30-day Free Trial. Pricing starts from $795 for 25 servers or applications! http://p.sf.net/sfu/zoho_dev2dev_nov _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
