Koki Sanagi <[email protected]> writes:

> +                     if (phy->speed_downgraded)
> +                             netdev_warn(netdev, "Link Speed was "
> +                                     "downgraded by SmartSpeed\n");
> +

Could you please avoid breaking the string both here and in the igb
patch?  This breaks the ability to grep for the warning.

Quoting Documentation/CodingStyle, Chapter 2:
"However, never break user-visible strings such as printk messages,
 because that breaks the ability to grep for them."


Bjørn

------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612 
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit 
http://communities.intel.com/community/wired

Reply via email to