> -----Original Message----- > From: Dan Carpenter [mailto:[email protected]] > Sent: Monday, January 21, 2013 11:15 AM > To: Wyborny, Carolyn > Cc: [email protected] > Subject: Re: igb: Add i2c interface to igb. > [..]
> It's just static analysis and reading the code (today's linux-next). > > We're not allowed to call kzalloc() with GFP_KERNEL while holding a spinlock. > It > will sometimes sleep and can lead to a lockup. One solution would be to use > GFP_ATOMIC. These bugs will generate a warning if you have > CONFIG_DEBUG_ATOMIC_SLEEP enabled. > > But as I mentioned, we never hit the GFP_KERNEL bug because we always take > the irqs_disabled() goto exit path since we disabled IRQs earlier in the > function > by calling spin_lock_irqsave(). > > regards, > dan carpenter Thanks for the additional info. I'll get a patch together for this as soon as possible. Carolyn ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
