-----Original Message-----
>From: Lloyd, Dave [mailto:[email protected]]
>Sent: Wednesday, January 23, 2013 12:56 PM
>To: [email protected]
>Subject: [E1000-devel] ixgbe multicast driver drops packets when adding
>additional multicast groups
>
>All:
>
>We recently upgraded some test systems to the ixgbe 3.7.14 driver from the
>ixgbe 3.3.9 driver. Sometime between 3.3.9 and 3.7.14 this line got added
>to ixgbe_write_mc_addr_list in ixgbe_main.c:
>
> hw->mac.ops.update_mc_addr_list(hw, NULL, 0, ixgbe_addr_list_itr, true);
>
>Unfortunately, this seems to have the effect of zeroing out the multicast
>address list the NIC is listening to before re-adding all the multicast
>addresses. This has the net effect of dropping packets from existing
>multicast streams when adding additional multicast sockets. I looked and
>this change also exists in the latest ixgbe 3.12.6 driver.
>
>Is there a reason why this clear was added? I looked through the mailing
>list and didn't find any references. I don't want to just comment out and
>recompile to resolve our particular situation if we run the risk of hitting
>another bug.
Hi Dave,
Thanks for reporting this issue. This is indeed a bug in the driver. Could
you please try the following patch (it should apply on top of 3.7.14):
--- ixgbe_main.c_orig 2013-01-23 15:27:25.599635002 -0800
+++ ixgbe_main.c 2013-01-23 15:29:00.860634866 -0800
@@ -4373,11 +4373,11 @@ int ixgbe_write_mc_addr_list(struct net_
if (!netif_running(netdev))
return 0;
+ if (netdev_mc_empty(netdev)) {
+ hw->mac.ops.update_mc_addr_list(hw, NULL, 0,
+ ixgbe_addr_list_itr, true);
- hw->mac.ops.update_mc_addr_list(hw, NULL, 0,
- ixgbe_addr_list_itr, true);
-
- if (!netdev_mc_empty(netdev)) {
+ } else {
#ifdef NETDEV_HW_ADDR_T_MULTICAST
ha = list_first_entry(&netdev->mc.list,
struct netdev_hw_addr, list);
And let us know if it resolves your issue.
>On a side note, I was trying to find a changelog for ixgbe_main.c . It
>looks like there is no source repo on Sourceforge. Should I be looking
>somewhere else?
For this type of info your best bet is looking at the git repository of the
Linux kernel.
http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=history;f=drivers/net/ethernet/intel/ixgbe/ixgbe_main.c;h=e7109de2204aecb75615bef77828ffe734646eb1;hb=HEAD
Thanks,
Emil
>
>Dave Lloyd
>Exegy, Inc.
>349 Marshall Rd., Ste. 100
>St. Louis, MO 63119 USA
>+1.314.218.3600 x 500
>Support: +1.314.218.3555
>[email protected]
>
>
>
>This e-mail and any documents accompanying it may contain legally
>privileged and/or confidential information belonging to Exegy, Inc. Such
>information may be protected from disclosure by law. The information is
>intended for use by only the addressee. If you are not the intended
>recipient, you are hereby notified that any disclosure or use of the
>information is strictly prohibited. If you have received this e-mail in
>error, please immediately contact the sender by e-mail or phone regarding
>instructions for return or destruction and do not use or disclose the
>content to others.
>
>---------------------------------------------------------------------------
>---
>Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
>MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
>with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
>MVPs and experts. ON SALE this month only -- learn more at:
>http://p.sf.net/sfu/learnnow-d2d
>_______________________________________________
>E1000-devel mailing list
>[email protected]
>https://lists.sourceforge.net/lists/listinfo/e1000-devel
>To learn more about Intel® Ethernet, visit
>http://communities.intel.com/community/wired
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
