On Wed, 2013-02-20 at 13:23 -0800, Alexander Duyck wrote: > NET_SKB_PAD is defined for the s390. It is already 32. If you look it > up we only have 2 definitions for NET_SKB_PAD, one specific to the s390 > architecture and the other one in skbuff.h. >
Andrew traces disagree, as they were : >>> s390 allmodconfig: >>> >>> bool __cond = !(!(((2048) - (((sizeof(struct skb_shared_info)) + (256 - 1)) >>> & >>> ~(256 - 1))) < (32 + 2 + 16 + 1514 + 4))); >>> So it might be only a cross-compile environment issue, I dont know. > From what I can tell we would have to drop the NET_SKB_PAD to 0 in order > to not trigger this error with igb since we still have to add 22 bytes > for igb's per packet timestamp header, IP alignment, and CRC. > > The simple fix is for us just to drop the BUILD_BUG_ON check for igb > since we already had a check for size check in igb_set_rx_buffer_len. > It just means that build_skb won't be available for standard MTU sizes > on s390. Yeah, probably nobody will notice ;) ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
