Ben Hutchings wrote: > On Tue, 2013-02-26 at 14:03 +0400, Konstantin Khlebnikov wrote: >> Waskiewicz Jr, Peter P wrote: >>> On 2/24/2013 9:19 PM, Konstantin Khlebnikov wrote: >>>> This patch fixes some annoying messages like 'Error reading PHY register' >>>> and >>>> 'Hardware Erorr' and saves several seconds on reboot. >>> >>> Any networking-related patches should also include net...@vger.kernel.org. >> >> Yeah, I forgot about this, since I came here from PCI-bus side, not from the >> network =) >> >>> >>> I'm also a bit confused how the changes below match the patch description. >> > Elaborating a bit more how the changes suppress the messages might be a >> good thing. >> >> Patch eliminates reason of these errors -- now driver will wake up >> the device before accessing to its registers. > [...] > > But e1000e calls netif_device_detach() when entering run-time suspend. > That currently prevents any ethtool operations from running until it > resumes.
This seems racy. dev_ethtool() runs under rtnl-lock, but suspend-resume run asynchronously. Runtime-suspend shoudn't call netif_device_detach(), logically device isn't dead it just take a nap for a while.. > > (This is definitely a misfeature of either the ethtool core or e1000e. > It is absolutely ridiculous that I can't check the PHY settings of an > e1000e - or even driver information! - when the link is down.) Ok link is down, but device still alive and I not see anything ridiculous in checking its registers. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired