Hi Eliezer,
(If I'm too late then a future note...)
Why make polling a system-wide configuration?
Wouldn't it make more sense to implement a sock option?
An even better solution might be aggregation/combination of both types of
configurations.
-- Yaniv Sa'ar
On Wed, May 29, 2013 at 5:01 PM, Eliezer Tamir <
[email protected]> wrote:
> On 29/05/2013 16:37, Eric Dumazet wrote:
>
>> On Wed, 2013-05-29 at 09:39 +0300, Eliezer Tamir wrote:
>>
>
> +static inline unsigned long ll_end_time(void)
>>> +{
>>> + return TSC_MHZ * ACCESS_ONCE(sysctl_net_ll_**poll) +
>>> get_cycles();
>>> +}
>>>
>>
>> This can overflow.
>>
>> Multiply is giving 32bits, as tsc_khz is an int, and sysctl_net_ll_poll
>> is an int.
>>
>> unsigned long sysctl_net_ll_poll ?
>>
> OK
>
>
> Also, if we want this to work on i386, the correct type to use for
>> ll_end_time(void) would be cycles_t
>>
>
> OK
> I would be really surprised if someone uses this on an i386, but I guess
> you never know.
>
> Thanks!
> -Eliezer
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at
> http://vger.kernel.org/**majordomo-info.html<http://vger.kernel.org/majordomo-info.html>
> Please read the FAQ at http://www.tux.org/lkml/
>
------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
