On 11/06/2013 23:24, Ben Hutchings wrote: > On Tue, 2013-06-11 at 17:24 +0300, Eliezer Tamir wrote: >> adds a socket option for low latency polling. >> This allows overriding the global sysctl value with a per-socket one. > [...] >> --- a/net/core/sock.c >> +++ b/net/core/sock.c >> @@ -913,6 +913,23 @@ set_rcvbuf: >> sock_valbool_flag(sk, SOCK_SELECT_ERR_QUEUE, valbool); >> break; >> >> +#ifdef CONFIG_NET_LL_RX_POLL >> + case SO_LL: >> + if (!capable(CAP_NET_ADMIN)) >> + ret = -EACCES; > [...] > > Failed capability checks normally result in EPERM whereas EACCES usually > results from a file permission/ACL/label check.
OK > Perhaps unprivileged users should be allowed to set a value as long as > it's less than or equal to the global value? I thought of allowing to disable even if you are not privileged, but this sounds better. Thanks! ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
