On 07/15/2013 09:49 PM, Alexander Duyck wrote: > On 07/13/2013 01:22 AM, jagdish.motw...@elitecore.com wrote: >>> On 07/12/2013 01:56 AM, Jagdish Motwani wrote: >>>> Hi list, >>>> I am facing a strange issue with igb driver. >>>> >>>> If i set my mtu to 1000, then ping -s 1200 does not work. (the same >>>> thing works with e1000e interface) >>>> >>>> On further debugging, i reached >>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec54d7d6e40b04c16dfce0e41e506198a20c8645 >>>> >>>> Reverting the patch, i was able to ping. >>>> >>>> The commit message states that it is a fix for skb_over panic. Is >>>> this fix still required? >>>> >>>> Regards, >>>> Jagdish Motwani >>> What version of the igb driver are you working with? We would need to >>> know that in order to determine if the fix is still needed or not. >>> >>> Thanks, >>> >>> Alex >>> >> Currently i am using version 3.3.6 but can move forward to 4.1.2 if required. >> >> Regards, >> Jagdish Motwani > So that version shouldn't have any issues with an skb_over_panic, > although simply reverting that patch isn't really advisable either as > there would be side effects that would likely limit performance. > > I am sending you a patch. If you can try testing that patch and letting > me know if it works for you I would appreciate it. All it does is limit > the max_frame_size to being no smaller than 1518 bytes in size in > igb_change_mtu. > > Thanks, > > Alex Hi Alex, I tried your patch and its working as expected.
Tcpdump of ping: eth0, OUT: IP 192.168.5.226 > 192.168.5.1: ICMP echo request, id 5127, seq 0, length 976 eth0, OUT: IP 192.168.5.226 > 192.168.5.1: icmp eth0, IN: IP 192.168.5.1 > 192.168.5.226: ICMP echo reply, id 5127, seq 0, length 1208 Thanks a lot. Regards, Jagdish Motwani ------------------------------------------------------------------------------ See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds. Start your free trial of AppDynamics Pro today! http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired