Currently carrier is forced off in igbvf_msix_other(). This seems unnecessary and causes multiple calls to igbvf_watchdog_task(), resulting in multiple link up messages when calling dhclient for example. [ 111.818106] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex [ 111.819347] IPv6: ADDRCONF(NETDEV_UP): eth5: link is not ready [ 111.820509] IPv6: ADDRCONF(NETDEV_CHANGE): eth5: link becomes ready [ 111.822983] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex [ 115.152421] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex compared to [ 1040.422161] igbvf 0000:00:04.0: Link is Up 1000 Mbps Full Duplex [ 1040.423447] IPv6: ADDRCONF(NETDEV_UP): eth5: link is not ready [ 1040.424622] IPv6: ADDRCONF(NETDEV_CHANGE): eth5: link becomes ready when this patch is applied.
Signed-off-by: Stefan Assmann <[email protected]> --- drivers/net/ethernet/intel/igbvf/netdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c index 93eb7ee..f041586 100644 --- a/drivers/net/ethernet/intel/igbvf/netdev.c +++ b/drivers/net/ethernet/intel/igbvf/netdev.c @@ -876,8 +876,6 @@ static irqreturn_t igbvf_msix_other(int irq, void *data) adapter->int_counter1++; - netif_carrier_off(netdev); - hw->mac.get_link_status = 1; if (!test_bit(__IGBVF_DOWN, &adapter->state)) mod_timer(&adapter->watchdog_timer, jiffies + 1); -- 1.8.3.1 ------------------------------------------------------------------------------ Get 100% visibility into Java/.NET code with AppDynamics Lite! It's a free troubleshooting tool designed for production. Get down to code-level detail for bottlenecks, with <2% overhead. Download for free and get started troubleshooting in minutes. http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
