> -----Original Message-----
> From: David Miller [mailto:[email protected]]
> Sent: Friday, August 23, 2013 12:28 AM
[...]
>
> > +{
> > + int i;
> > + struct i40e_pf *pf = vsi->back;
>
> Please order local variable declarations from longest line to shortest.
I understand the aesthetics as it does make the code look a little cleaner, and
we can do this with a lot of our functions. However, there are several
instances where one declaration initialization depends on a previous
declaration, and trying to organize by line length breaks these relationships.
Do you mind if we're not perfect on following this one?
Also, perhaps I haven't watched closely enough, but I don't remember seeing
this comment on other code. Is this a new recommendation that will be going
into the CodingStyle document?
Thanks,
sln
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
