> -----Original Message----- > From: Joe Perches [mailto:j...@perches.com] > Sent: Friday, August 30, 2013 9:33 AM >
Hi Joe, thanks for your comments, and we're working through another version to be posted Real Soon. In the meantime I thought I'd respond to a couple specific comments. > > +#define DRV_KERN "-k" > > + > > +#define DRV_VERSION_MAJOR 0 > > +#define DRV_VERSION_MINOR 3 > > +#define DRV_VERSION_BUILD 8 > > +#define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \ > > + __stringify(DRV_VERSION_MINOR) "." \ > > + __stringify(DRV_VERSION_BUILD) DRV_KERN > > does "-k" add/signify anything useful? The "-k" helps us to quickly spot that a customer is asking us about the upstream version of our driver and not an out-of-tree (e.g. SourceForge) version. [...] > > > +/** > > + * i40e_get_netdev_stats_struct - Get statistics for netdev interface > > + * @netdev: network interface device structure > > + * > > + * Returns the address of the device statistics structure. > > + * The statistics are actually updated from the service task. > > + **/ > > +static struct rtnl_link_stats64 *i40e_get_netdev_stats_struct( > > + struct net_device *netdev, > > + struct rtnl_link_stats64 *storage) > > An alternative bsd declaration style might be > more readable for these very long types and names. > > static struct rtnl_link_stats64 * > i40e_get_netdev_stats_struct(struct net_device *netdev, > struct rtnl_link_stats64 *storage) We're trying to stay consistent in kernel function styles, stay within standard checkpatch restrictions, and keep the code readable and maintainable, which all together make for some difficult choices. No matter which way we go on some of these decisions, we run into the painfully gray opinion areas of how someone else might have solved the problems. sln ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
