Stephen Hemminger <step...@networkplumber.org> writes: > More surprising is that others did not see the same things.
If I were to guess the 3 primary reasons for that: 1) the series is too large for anyone to actually read it all without being paid to do so 2) the sysfs code is at the end of a huge debugfs patch, which probably noone cares about whether they are paid or not 3) the small sysfs patch is so full of minor issues to nit about that it seems pointless to even start But since I looked at it, I can name a few other obvious issues with the sysfs patch: - mix of macro and octal mode values - no documentation (required for all new sysfs attributes according to Documentation/filesystems/sysfs.txt) - extremely dubious kboject usage and attribute creation/deletion (How does this fit into the driver model? How will userspace race with these attributes being added and removed?) I am sure there are plenty more. Bjørn ------------------------------------------------------------------------------ Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more! Discover the easy way to master current and previous Microsoft technologies and advance your career. Get an incredible 1,500+ hours of step-by-step tutorial videos with LearnDevNow. Subscribe today and save! http://pubads.g.doubleclick.net/gampad/clk?id=58041391&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired