On Tue, 2013-09-24 at 15:07 -0700, Jeff Kirsher wrote: > On Tue, 2013-09-24 at 14:09 -0700, Joe Perches wrote: > > There are a mix of function prototypes with and without extern > > in the kernel sources. Standardize on not using extern for > > function prototypes. > > > > Function prototypes don't need to be written with extern. > > extern is assumed by the compiler. Its use is as unnecessary as > > using auto to declare automatic/local variables in a block. > > So you are able to confirm that all compilers make this assumption > correctly? The initial reason for using extern was because not all > compilers made the assumption or made it correctly.
No, I didn't bother. Any current compilers already do make this assumption valid as it's been part of the c spec since 1989 and prototypes without extern already are the predominate form in .h files for linux kernel sources. Even in drivers/net/ethernet/intel/... there are more prototypes without extern than with extern. ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
