On Tue, Oct 08, 2013 at 09:33:02AM +0200, Alexander Gordeev wrote: > On Tue, Oct 08, 2013 at 03:33:30PM +1100, Michael Ellerman wrote: > > On Wed, Oct 02, 2013 at 12:29:04PM +0200, Alexander Gordeev wrote: > > > This technique proved to be confusing and error-prone. Vast share > > > of device drivers simply fail to follow the described guidelines. > > > > To clarify "Vast share of device drivers": > > > > - 58 drivers call pci_enable_msix() > > - 24 try a single allocation and then fallback to MSI/LSI > > - 19 use the loop style allocation as above > > - 14 try an allocation, and if it fails retry once > > - 1 incorrectly continues when pci_enable_msix() returns > 0 > > > > So 33 drivers (> 50%) successfully make use of the "confusing and > > error-prone" return value. > > Ok, you caught me - 'vast share' is incorrect and is a subject to > rewording. But out of 19/58 how many drivers tested fallbacks on the > real hardware? IOW, which drivers are affected by the pSeries quota?
It's not 19/58, it's 33/58. As to how many we care about on powerpc I can't say, so you have a point there. But I still think the interface is not actually that terrible. cheers ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
